RFR for JDK-8031661 java/net/Authenticator/B4769350.java failed intermittently

2014-02-10 Thread Amanda Jiang
Hi All, Please review the fix for JDK-8031661 http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/ Description: Root Cause: In line 195 and 196, the two actions can be ordered by a happens-before relationship, which will cause synchronization fail. t1cond1latch.countDown(); t1cond2

Re:Re:RFR for JDK-8031661 java/net/Authenticator/B4769350.java failed intermittently

2014-02-10 Thread Amanda Jiang
n the updated test for a while and I can't see any problem with it. Thanks, Michael On 10/02/14 08:56, Amanda Jiang wrote: Hi All, Please review the fix for JDK-8031661 http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/ <http://cr.openjdk.java.net/%7Etyan/amanda

Re: RFR for JDK-8031661 java/net/Authenticator/B4769350.java failed intermittently

2014-02-12 Thread Amanda Jiang
Hi Michael, Could you sponsor this for me? Thanks a lot. Amanda On 2/10/14 4:10 PM, Amanda Jiang wrote: > Hi Michael, > > Could you sponsor this for me? > > Thanks, > Amanda > > *发件人**:*Michael McMahon > *发送时间**:*Monday, February 10, 2014 6:13 PM > *收件人**:*net-de

RFR for JDK-8038276 java/net/NetworkInterface/Test.java fails on windows intermittently for Teredo Interface

2014-03-27 Thread Amanda Jiang
Hi All , Please check and review following changes: http://cr.openjdk.java.net/~ewang/amanda/JDK-8038276/webrev.00/ Description of issue: Root Cause: Test java/net/NetworkInterface/Test.java failed because virtual interface "Teredo Tunneling Pseudo-Interface" on windows returned random address

Re: RFR for JDK-8038276 java/net/NetworkInterface/Test.java fails on windows intermittently for Teredo Interface

2014-03-28 Thread Amanda Jiang
Please sponsor this change . Thank you, Chris. Amanda On 3/28/14 6:10 AM, Chris Hegarty wrote: Looks ok to me Amanda. I can sponsor this change, if needed. -Chris. On 28/03/14 05:07, Amanda Jiang wrote: Hi All , Please check and review following changes: http://cr.openjdk.java.net/~ewang

RFR 8047031: Need new tests to check socket permission

2014-07-28 Thread Amanda Jiang
Hi All, Could you please review 1 new test to be added for SocketPermission. New test is added to check socket permissions, for instance - - java.net.SocketPermission with "connect", "resolve", "accept", "listen" with Socket, DatagramSocket, MulticastSocket etc. JDK Issue: https://bugs.openjdk.j

Re: RFR 8047031: Need new tests to check socket permission

2014-08-25 Thread Amanda Jiang
Hi Michael, Chris and others We’re working on moving our internal security tests to open idk repo(Include refactoring effort). Could you please help to review these tests? Thanks, Amanda On 7/28/14 5:25 PM, Amanda Jiang wrote: Hi All, Could you please review 1 new test to be added for

Re: RFR 8047031: Need new tests to check socket permission

2014-08-29 Thread Amanda Jiang
reate the socket permission instances dynamically accordingly? Or would this make the test very difficult to debug? -Chris. On 25/08/14 17:48, Amanda Jiang wrote: Hi Michael, Chris and others We’re working on moving our internal security tests to open idk repo(Include refactoring effort). Coul

RFR 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs

2014-12-05 Thread Amanda Jiang
Hi, May I request your review for following changeset? There are 33 networking tests that have dependency on internal APIsun.net.www.MessageHeader and sun.net.www.HeaderParser This fix is to remove the internal API dependency from those tests. bug: https://bugs.openjdk.java.net/browse/JDK-80617

RFR 8065420: Update test java/net/ResponseCache/ResponseCacheTest.java to eliminate internal API dependency

2014-12-17 Thread Amanda Jiang
Hi, May I request your review for following changeset? There is one networking tests that has dependency on internal API sun.net.www.ParseUtil. This fix is to remove the internal API dependency from that test. bug:https://bugs.openjdk.java.net/browse/JDK-8065420 webrev: http://cr.openjdk.java.n

Re: RFR 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs

2014-12-22 Thread Amanda Jiang
I have updated the fixes to reduce code duplication, please check the new webrev below: http://cr.openjdk.java.net/~tyan/amandaj/8061729/webrev/ Thanks, Amanda On 12/5/14 1:58 PM, Amanda Jiang wrote: Hi, May I request your review for following changeset? There are 33 networking tests that

Re: RFR 8065420: Update test java/net/ResponseCache/ResponseCacheTest.java to eliminate internal API dependency

2014-12-22 Thread Amanda Jiang
Thank you Chris, could you please sponsor this? Thanks, Amanda On 12/18/14 4:18 AM, Chris Hegarty wrote: This looks ok to me Amanda. -Chris. On 17 Dec 2014, at 23:23, Amanda Jiang wrote: Hi, May I request your review for following changeset? There is one networking tests that has