Hi,
Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
and is causing failures on older versions of macOS that do not support the
option. The fix here is to check at initialization time whether it is supported
before adding it to the list of supported options. The err
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote:
> Hi,
>
> Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
> and is causing failures on older versions of macOS that do not support the
> option. The fix here is to check at initialization time whether it is
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote:
> Hi,
>
> Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
> and is causing failures on older versions of macOS that do not support the
> option. The fix here is to check at initialization time whether it is
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote:
> Hi,
>
> Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
> and is causing failures on older versions of macOS that do not support the
> option. The fix here is to check at initialization time whether it is
On Wed, 27 Apr 2022 11:02:08 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Can I get the following fix reviewed please? JDK-8284890 was pushed
>> yesterday and is causing failures on older versions of macOS that do not
>> support the option. The fix here is to check at initialization time whether
>>
> Hi,
>
> Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
> and is causing failures on older versions of macOS that do not support the
> option. The fix here is to check at initialization time whether it is
> supported before adding it to the list of supported opti
On Wed, 27 Apr 2022 12:10:13 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Can I get the following fix reviewed please? JDK-8284890 was pushed
>> yesterday and is causing failures on older versions of macOS that do not
>> support the option. The fix here is to check at initialization time whether
On Wed, 27 Apr 2022 14:10:55 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated test
>
> src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c line 209:
>
>> 207: return JNI_F
On Wed, 27 Apr 2022 14:12:40 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated test
>
> test/jdk/jdk/net/ExtendedSocketOption/DontFragmentTest.java line 44:
>
>> 42:
>> 43: public s
> Hi,
>
> Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
> and is causing failures on older versions of macOS that do not support the
> option. The fix here is to check at initialization time whether it is
> supported before adding it to the list of supported opti
On Sun, 27 Feb 2022 14:11:28 GMT, Michael Felt wrote:
>> with IP "0.0.0.0"
>>
>> - it either does nothing and ping fails, or, in some virtual environments
>> is treated as the default route address.
>> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted
>> as a vaild psu
On Tue, 26 Apr 2022 18:46:02 GMT, Bradford Wetmore wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/SSLSessionBindingEvent.java line 37:
>
>> 35:
On Mon, 28 Feb 2022 10:25:44 GMT, Daniel Fuchs wrote:
>> Michael Felt has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new comm
> with IP "0.0.0.0"
>
> - it either does nothing and ping fails, or, in some virtual environments
> is treated as the default route address.
> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted
> as a vaild psuedo IPv6 address. '::1' must be used instead.
>
> ping: bind:
On Wed, 27 Apr 2022 15:27:45 GMT, Michael Felt wrote:
>> with IP "0.0.0.0"
>>
>> - it either does nothing and ping fails, or, in some virtual environments
>> is treated as the default route address.
>> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted
>> as a vaild psu
On Wed, 27 Apr 2022 14:27:01 GMT, Michael McMahon wrote:
>> src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c line 209:
>>
>>> 207: return JNI_FALSE;
>>> 208: }
>>> 209: fd = socket(AF_INET6, SOCK_DGRAM, 0);
>>
>> So if IPv6 is not supported on the machine, won't that re
On Wed, 27 Apr 2022 14:57:34 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Can I get the following fix reviewed please? JDK-8284890 was pushed
>> yesterday and is causing failures on older versions of macOS that do not
>> support the option. The fix here is to check at initialization time whether
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote:
> Hi,
>
> Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday
> and is causing failures on older versions of macOS that do not support the
> option. The fix here is to check at initialization time whether it is
On Wed, 27 Apr 2022 15:22:08 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLSessionBindingEvent.java line
>> 37:
>>
>>> 35: * {@link SSLSession#putValue(String, Object)}
>>> 36: * or {@link SSLSession#removeValue(String)}, objects which
>>> 37: * implement the SSLSes
On Tue, 26 Apr 2022 19:08:50 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java line 96:
>
>> 94:
On Tue, 26 Apr 2022 22:08:42 GMT, Weijun Wang wrote:
>> Perhaps as part of
>> [JDK-6725221](https://bugs.openjdk.java.net/browse/JDK-6725221)?
>
> No problem.
JDK-6725221 is about obtaining boolean properties, so not an exact match. The
suggested change is so easy, I'm going to do it.
---
On Tue, 26 Apr 2022 19:09:46 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java line 81:
>
>> 79: S
On Wed, 27 Apr 2022 19:12:37 GMT, Mark Powers wrote:
>> No problem.
>
> JDK-6725221 is about obtaining boolean properties, so not an exact match. The
> suggested change is so easy, I'm going to do it.
sun.security.action.GetPropertyAction::privilegedGetProperty doesn't trim the
return value. C
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/java.base/share/classes/java/net
Mark Powers has u
24 matches
Mail list logo
