On Wed, 27 Apr 2022 11:02:08 GMT, Daniel Fuchs <[email protected]> wrote:
>> Hi,
>>
>> Can I get the following fix reviewed please? JDK-8284890 was pushed
>> yesterday and is causing failures on older versions of macOS that do not
>> support the option. The fix here is to check at initialization time whether
>> it is supported before adding it to the list of supported options. The error
>> causes the new test and two existing ones to fail. I will remove the two
>> tests from the problem list separately.
>>
>> Thanks,
>> Michael.
>
> test/jdk/jdk/net/ExtendedSocketOption/DontFragmentTest.java line 62:
>
>> 60:
>> 61: if (!c1.supportedOptions().contains(IP_DONTFRAGMENT)) {
>> 62: return;
>
> Should we assert that this should only happens on mac here? Same remark for
> the two other places below...
I think that is reasonable.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8419
