On Fri, 25 Mar 2022 17:21:11 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> forgot update to DigestAuth test
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
On Mon, 28 Mar 2022 08:22:26 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
>> line 524:
>>
>>> 522: }
>>> 523:
>>> 524: boolean session = algorithm.endsWith ("-sess");
>>
>> should that be `digest.endsWith("-sess
> **Problem**
> When a Continuation Frame is received by the httpclient using HTTP/2 after a
> Push Promise frame (can happen if the amount of headers to be sent in a
> single Push Promise frame exceeds the maximum frame size, so a Continuation
> frame is required), the following exception occur
On Fri, 25 Mar 2022 15:55:54 GMT, Conor Cleary wrote:
>> Oh yes, good point. I think `ErrorFrame.PROTOCOL_ERROR` would be the most
>> appropriate here. I'll amend the change accordingly.
>
> However, I'll look into the specification further for the other cases and see
> if they need be changed
On Mon, 28 Mar 2022 09:29:58 GMT, Daniel Fuchs wrote:
>> No, the digest field refers to the actual message digest algorithm (as known
>> to the security libraries). The algorithm field holds the algorithm name as
>> it is defined in RFC7616.
>
> I am confused here - because you converted `algo
On Fri, 25 Mar 2022 15:07:40 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system pro
On Mon, 28 Mar 2022 10:30:56 GMT, Michael McMahon wrote:
>> I am confused here - because you converted `algorithm` to upper case, so it
>> should never end with `-sess`?
>
> Look at line 478: The `algorithm` field is reset here to be the upper case of
> the digest name plus the -sess suffix in
On Mon, 28 Mar 2022 10:22:29 GMT, Conor Cleary wrote:
>> However, I'll look into the specification further for the other cases and
>> see if they need be changed as well. Though closing the whole connection
>> with `GoAwayFrame` seems correct
>
> I changed three more occurences to `ErrorFrame.P
On Mon, 28 Mar 2022 10:26:24 GMT, Conor Cleary wrote:
>> **Problem**
>> When a Continuation Frame is received by the httpclient using HTTP/2 after a
>> Push Promise frame (can happen if the amount of headers to be sent in a
>> single Push Promise frame exceeds the maximum frame size, so a Conti
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
> "http.auth.digest.reEnabledAlgs" to include the value M
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
This pull request has now been integrated.
Changeset: c0aecd15
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/c0aecd15ae8d7abf37901f785fccaff2317c3b23
Stat
This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
-
Commit messages:
- Revert "8280400: JDK 19 L10n resource files update - msgdrop 10"
Changes: https://git.openjdk.java.net/jdk/pull/8005/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8005&range=00
Issue:
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
I confirm that this is an exact backout of
[JDK-8280400](https://bugs.openjdk.java.net/browse/JDK-8280400).
-
Marked as reviewed by kcr (Author).
PR: https://git.
The following fix seals `sun.net.dns.ResolverConfiguration` abstract class.
`sun.net.dns.ResolverConfigurationImpl` is the only permitted subclass which
has two O/S specific implementations: for `Windows` and `Unix` architectures.
Both of them are marked as `final`.
Testing: `jdk-tier1`, `jdk-ti
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8005
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
This pull request has now been integrated.
Changeset: 634800a5
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/634800a536e7f9
17 matches
Mail list logo
