Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-15 Thread Michael McMahon
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created, and

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-15 Thread Michael McMahon
On Mon, 14 Mar 2022 13:21:21 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java >> line 155: >> >>> 153: boolean offerConnection(Http2Connection c) { >>> 154: if (debug.on()) debug.log("offering to the connection pool: >>> %s", c)

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v3]

2022-03-15 Thread Michael McMahon
On Fri, 11 Mar 2022 18:12:27 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update after second review round > > src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

2022-03-15 Thread Conor Cleary
On Mon, 14 Mar 2022 11:19:36 GMT, Conor Cleary wrote: >> test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 176: >> >>> 174: ContinuationFrame cf = new ContinuationFrame(streamid, >>> HeaderFrame.END_HEADERS, encodedHeaders); >>> 175: >>> 176: try { >>

Integrated: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently

2022-03-15 Thread Daniel Fuchs
On Thu, 10 Mar 2022 16:44:53 GMT, Daniel Fuchs wrote: > Please find enclosed a patch that solves an intermittent issue detected by > the CancelRequestTest.java > > If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled > after the Http2Connection has been created, and the

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v3]

2022-03-15 Thread Daniel Fuchs
On Tue, 15 Mar 2022 10:24:43 GMT, Michael McMahon wrote: >> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java >> line 102: >> >>> 100: propPrefix + "reEnabledAlgorithms"; >>> 101: >>> 102: private static final Set disabledAlgorithms = new >>> HashSet<

Re: RFR: 8282536: java.net.InetAddress should be a sealed class [v2]

2022-03-15 Thread Michael McMahon
On Mon, 14 Mar 2022 16:45:24 GMT, Aleksei Efimov wrote: >> The following fix seals the `java.net.InetAddress` class and permits only >> two implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. >> >> No issues have been detected by regression and JCK tests. >> >> Links: [JBS]

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

2022-03-15 Thread Daniel Fuchs
On Tue, 15 Mar 2022 11:26:55 GMT, Conor Cleary wrote: >> Good idea yes, to check that the repeat continuation still behaves as >> expected. Should hopefully be straight forward to create another test case. > > On this issue, there is a case where a faulty server might send an indefinite > numbe

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

2022-03-15 Thread Conor Cleary
On Mon, 7 Mar 2022 12:31:41 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263031: Tidied up import statements > > src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > l

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v3]

2022-03-15 Thread Conor Cleary
> **Problem** > When a Continuation Frame is received by the httpclient using HTTP/2 after a > Push Promise frame (can happen if the amount of headers to be sent in a > single Push Promise frame exceeds the maximum frame size, so a Continuation > frame is required), the following exception occur

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v3]

2022-03-15 Thread Daniel Fuchs
On Tue, 15 Mar 2022 14:54:35 GMT, Conor Cleary wrote: >> **Problem** >> When a Continuation Frame is received by the httpclient using HTTP/2 after a >> Push Promise frame (can happen if the amount of headers to be sent in a >> single Push Promise frame exceeds the maximum frame size, so a Conti

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

2022-03-15 Thread Conor Cleary
On Mon, 7 Mar 2022 12:08:49 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263031: Tidied up import statements > > src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > l

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v4]

2022-03-15 Thread Conor Cleary
> **Problem** > When a Continuation Frame is received by the httpclient using HTTP/2 after a > Push Promise frame (can happen if the amount of headers to be sent in a > single Push Promise frame exceeds the maximum frame size, so a Continuation > frame is required), the following exception occur

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v6]

2022-03-15 Thread Michael McMahon
> Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new system property > "http.auth.digest.reEnabledAlgs" to include the value M

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v6]

2022-03-15 Thread Daniel Fuchs
On Tue, 15 Mar 2022 16:00:41 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system pro

Re: RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive [v2]

2022-03-15 Thread Weijun Wang
On Thu, 10 Mar 2022 05:59:14 GMT, Sibabrata Sahoo wrote: >> Domain value for system property jdk.https.negotiate.cbt is >> case-insensitive now. Included Test has been updated to address the change. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit sin

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v6]

2022-03-15 Thread Sean Mullan
On Tue, 15 Mar 2022 16:00:41 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system pro