On Mon, 7 Mar 2022 12:31:41 GMT, Daniel Fuchs <[email protected]> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8263031: Tidied up import statements
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
> line 855:
>
>> 853:
>> 854: private record PushContinuationState(HeaderDecoder pushContDecoder,
>> PushPromiseFrame pushContFrame) {}
>> 855: private volatile PushContinuationState pcs;
>
> I'd prefer to have a longer name than `pcs` - `pushContinuationState` would
> make it less mysterious at the place where it's used. Also it could be good
> to move these declarations (linew 854 and 855) higher in the file, where
> other instance variables are declared.
Changed to pushContinuationState, its a long name but definitely clearer
-------------
PR: https://git.openjdk.java.net/jdk/pull/7696