Re: RFR: JDK-8061729 : Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v5]

2022-02-15 Thread Daniel Fuchs
On Fri, 11 Feb 2022 11:15:56 GMT, Mahendra Chhipa wrote: >> There are some regression tests depending on sun.net.www.MessageHeader, the >> internal API dependency should be removed. Some of other internal API >> dependancies are removed in following issues : >> JDK-8273142 >> JDK-8268464 >> JDK

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v3]

2022-02-15 Thread Michael McMahon
On Mon, 14 Feb 2022 13:38:06 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commit

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v4]

2022-02-15 Thread Michael McMahon
> Hi, > > Could I get the following patch reviewed please? (A CSR is also required > which I will submit when the docs are agreed) > > It adds a pair of new system properties to make the keep alive timer in > java.net.HttpURLConnection configurable. > The proposed property names are: > > "http

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v4]

2022-02-15 Thread Daniel Fuchs
On Tue, 15 Feb 2022 13:30:35 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following patch reviewed please? (A CSR is also required >> which I will submit when the docs are agreed) >> >> It adds a pair of new system properties to make the keep alive timer in >> java.net.HttpURLConn

RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects.

2022-02-15 Thread Conor Cleary
As described in the title, this is a simple change to the `HttpRequest.Builder::build` method to highlight that an immutable and reusable instance of an `HttpRequest` is created when this method is invoked. This is done by adding an `@implSpec` Javadoc Tag (details on `@implSpec` given [here](h

Re: RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects.

2022-02-15 Thread Daniel Fuchs
On Tue, 15 Feb 2022 14:05:16 GMT, Conor Cleary wrote: > As described in the title, this is a simple change to the > `HttpRequest.Builder::build` method to highlight that an immutable and > reusable instance of an `HttpRequest` is created when this method is invoked. > This is done by adding an

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5]

2022-02-15 Thread Michael McMahon
> Hi, > > Could I get the following patch reviewed please? (A CSR is also required > which I will submit when the docs are agreed) > > It adds a pair of new system properties to make the keep alive timer in > java.net.HttpURLConnection configurable. > The proposed property names are: > > "http

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5]

2022-02-15 Thread Daniel Fuchs
On Tue, 15 Feb 2022 15:18:46 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following patch reviewed please? (A CSR is also required >> which I will submit when the docs are agreed) >> >> It adds a pair of new system properties to make the keep alive timer in >> java.net.HttpURLConn

Re: RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects.

2022-02-15 Thread Conor Cleary
On Tue, 15 Feb 2022 15:04:12 GMT, Daniel Fuchs wrote: >> As described in the title, this is a simple change to the >> `HttpRequest.Builder::build` method to highlight that an immutable and >> reusable instance of an `HttpRequest` is created when this method is >> invoked. This is done by addin

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v6]

2022-02-15 Thread Michael McMahon
> Hi, > > Could I get the following patch reviewed please? (A CSR is also required > which I will submit when the docs are agreed) > > It adds a pair of new system properties to make the keep alive timer in > java.net.HttpURLConnection configurable. > The proposed property names are: > > "http

Re: RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects. [v2]

2022-02-15 Thread Conor Cleary
> As described in the title, this is a simple change to the > `HttpRequest.Builder::build` method to highlight that an immutable and > reusable instance of an `HttpRequest` is created when this method is invoked. > This is done by adding an `@implSpec` Javadoc Tag (details on `@implSpec` > give

Re: RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects. [v2]

2022-02-15 Thread Daniel Fuchs
On Tue, 15 Feb 2022 15:33:01 GMT, Conor Cleary wrote: >> As described in the title, this is a simple change to the >> `HttpRequest.Builder::build` method to highlight that an immutable and >> reusable instance of an `HttpRequest` is created when this method is >> invoked. This is done by addin

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v6]

2022-02-15 Thread Daniel Fuchs
On Tue, 15 Feb 2022 15:30:07 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following patch reviewed please? (A CSR is also required >> which I will submit when the docs are agreed) >> >> It adds a pair of new system properties to make the keep alive timer in >> java.net.HttpURLConn

RFR: 8281305: Test com/sun/net/httpserver/simpleserver/MapToPathTest.java fails on Windows 11

2022-02-15 Thread Julia Boes
This change adds a check for URI path segments that look like a root drive on Windows, e.g. "C:". Such path segments are not supported because a request path should really be relative to the working directory. The check is implemented with a platform-specific helper class, some additional test