Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java [v2]

2022-01-13 Thread Daniel Fuchs
On Thu, 13 Jan 2022 03:26:58 GMT, Jaikiran Pai wrote: >> Can I please get a review for this test only change which proposes to enable >> debug logs from the test that failed intermittently? This change addresses >> https://bugs.openjdk.java.net/browse/JDK-8278961. >> >> The change passes the (

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-13 Thread Jaikiran Pai
On Fri, 17 Dec 2021 16:35:18 GMT, Daniel Jelinski wrote: >> Can I please get a review for this test only change which proposes to enable >> debug logs from the test that failed intermittently? This change addresses >> https://bugs.openjdk.java.net/browse/JDK-8278961. >> >> The change passes th

Integrated: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-13 Thread Jaikiran Pai
On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai wrote: > Can I please get a review for this test only change which proposes to enable > debug logs from the test that failed intermittently? This change addresses > https://bugs.openjdk.java.net/browse/JDK-8278961. > > The change passes the (test

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v6]

2022-01-13 Thread Jaikiran Pai
On Wed, 12 Jan 2022 08:48:12 GMT, Jaikiran Pai wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a specif

Integrated: 8262442: (windows) Use all proxy configuration sources when java.net.useSystemProxies=true

2022-01-13 Thread Daniel Jelinski
On Mon, 18 Oct 2021 19:25:12 GMT, Daniel Jelinski wrote: > With this patch DefaultProxySelector first attempts to use proxy config > autodetection (http://wpad/wpad.dat) when that is configured and available. > If proxy config autodetection is unavailable, selector tries to use > configured pro

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-13 Thread Julia Boes
> This new test confirms that the jwebserver does not wait indefinitely for a > request to arrive, but instead closes the connection when the maximum request > time is reached. To facilitate this, Exchange::run is amended to process > cancelled keys in the case where the current thread is the di

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-13 Thread Julia Boes
On Thu, 13 Jan 2022 04:52:25 GMT, Jaikiran Pai wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address PR comments: >> * remove redundant null check >> * use try-finally to stop process in test > > src/jdk.httpse

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-13 Thread Jaikiran Pai
Thank you Julia, these new changes look fine to me. -Jaikiran On 13/01/22 9:09 pm, Julia Boes wrote: On Thu, 13 Jan 2022 04:52:25 GMT, Jaikiran Pai wrote: Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comments: *