On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

> Can I please get a review for this test only change which proposes to enable 
> debug logs from the test that failed intermittently? This change addresses 
> https://bugs.openjdk.java.net/browse/JDK-8278961.
> 
> The change passes the (test specific) `-d` option to enable logs from that 
> test by default. While I was at it, I even added a few more debug logs hoping 
> it might provide some hints if/when it fails next.
> 
> For reference, a (successful) run of this test will now print something like:
> 
> 
> ----------System.out:(18/930)----------
> running on OS that supports ICMP port unreachable
> Testing with class java.net.DatagramSocket
> tests will be run against destination address localhost/127.0.0.1 port 52682
> Checking send to connected address ...
> socket is locally bound to address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> Checking send to non-connected address ...
> received data from address /127.0.0.1 port 52681
> Checking send to invalid address ...
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException

This pull request has now been integrated.

Changeset: c17a0122
Author:    Jaikiran Pai <j...@openjdk.org>
URL:       
https://git.openjdk.java.net/jdk/commit/c17a0122c4b5f17b85dc0bee0777b2a831debf6d
Stats:     9 lines in 1 file changed: 7 ins; 0 del; 2 mod

8278961: Enable debug logging in 
java/net/DatagramSocket/SendDatagramToBadAddress.java

Reviewed-by: dfuchs, msheppar

-------------

PR: https://git.openjdk.java.net/jdk/pull/6883

Reply via email to