RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Jaikiran Pai
This change proposes to implement the enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8209137. The change introduces a new API to allow applications to build a `java.net.http.HTTPClient` configured with a specific local address that will be used while creating `Socket`(s) for conn

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Daniel Fuchs
On Fri, 3 Dec 2021 06:15:31 GMT, Jaikiran Pai wrote: > This change proposes to implement the enhancement noted in > https://bugs.openjdk.java.net/browse/JDK-8209137. > > The change introduces a new API to allow applications to build a > `java.net.http.HTTPClient` configured with a specific loc

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Jaikiran Pai
On Fri, 3 Dec 2021 17:29:44 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java line 74: >> >>> 72: >>> 73: @BeforeClass >>> 74: public static void beforeClass() throws Exception { >> >> For HttpClient tests - unless they are specific to HTTP/1.1 I'd r

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Daniel Fuchs
On Fri, 3 Dec 2021 17:28:25 GMT, Daniel Fuchs wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a specifi

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Daniel Fuchs
On Tue, 7 Dec 2021 14:33:40 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java line 205: >> >>> 203: // anyAddress >>> 204: if (Boolean.getBoolean("java.net.preferIPv6Addresses")) { >>> 205: // ipv6 wildcard >> >> ::1 is

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Jaikiran Pai
On Wed, 8 Dec 2021 01:22:50 GMT, Jaikiran Pai wrote: >> You could also replace `Boolean.getBoolean("java.net.preferIPv6Addresses")` >> with a call to `IPSupport::preferIPv6Addresses()` > >> ::1 is the ipv6 loopback - not the ipv6 wildcard > > Oops, that's embarrassing and it isn't even a copy/p

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client

2021-12-10 Thread Jaikiran Pai
On Tue, 7 Dec 2021 14:35:27 GMT, Daniel Fuchs wrote: >> You may encounter some issues when testing with https and IPv6 - Michael is >> working on a fix to add the loopback addresses as SNI aliases to the >> SimpleSSLContext certificate: >> https://bugs.openjdk.java.net/browse/JDK-8278312 > > Yo

RFR: Merge jdk18

2021-12-10 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162 - 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated - 8273179: Update nroff pages in JDK

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v5]

2021-12-10 Thread Andrey Turbanov
> 8274809: Update java.base classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274809: Update java.base classes to use try-with-resources move { to previous line - Changes: - all: h

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-10 Thread Andrey Turbanov
On Tue, 7 Dec 2021 07:59:54 GMT, Alan Bateman wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274809: Update java.base classes to use try-with-resources >> fix review comments > > src/java.base/share/classes/

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-10 Thread Andrey Turbanov
On Tue, 7 Dec 2021 14:48:17 GMT, Daniel Fuchs wrote: >Remind me to sponsor this after the fork. fork is done :) - PR: https://git.openjdk.java.net/jdk/pull/5818

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-10 Thread Andrey Turbanov
On Thu, 9 Dec 2021 01:25:20 GMT, Bradford Wetmore wrote: >> That's one of the places where I personally would always use the var keyword >> too: it makes the line shorter and the type is already clearly visible in >> the RHS of the assignment, so repeating it on the left hand side does not >>

Integrated: Merge jdk18

2021-12-10 Thread Jesper Wilhelmsson
On Fri, 10 Dec 2021 17:51:31 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 61736f81 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/61736f81fb4a20375c83d59e2b37a00aafb11107 Stats: 1142