On Fri, 3 Dec 2021 17:29:44 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java line 74:
>> 
>>> 72: 
>>> 73:     @BeforeClass
>>> 74:     public static void beforeClass() throws Exception {
>> 
>> For HttpClient tests - unless they are specific to HTTP/1.1 I'd recommend 
>> making the test class implement HttpServerAdapters and test will all 
>> versions of the protocol (http, https, http/2, and https/2).
>> An example can be found in e.g. 
>> `test/jdk/java/net/httpclient/CancelRequestTest.java`
>
> Also it's better if the test is IP version agnostic.

Hello Daniel, I will update the test accordingly in the next round of updates.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6690

Reply via email to