I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
method.
It's makes code a bit easier to read.
-
Commit messages:
- [PATCH] Use Optional.isEmpty instead of !Optional.isPresent in java.net.http
Changes: https://git.openjdk.java.net/jdk/pull/5985/files
Webr
On Mon, 18 Oct 2021 07:55:52 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5985
On Mon, 15 Nov 2021 13:25:01 GMT, Daniel Fuchs wrote:
> Hi Jaikiran, is this still an issue now that Jar Index is disabled by
> default? (see https://git.openjdk.java.net/jdk/pull/5524)
Hello Daniel,
The issue is still reproducible (only) if the jar indexing is enabled by
setting the `-Djdk.ne
On Mon, 15 Nov 2021 13:26:30 GMT, Jaikiran Pai wrote:
> Hello Daniel, The issue is still reproducible (only) if the jar indexing is
> enabled by setting the `-Djdk.net.URLClassPath.enableJarIndex=true`
Just to add to Daniel's comment. JAR indexing has several issues, most going
back 20+ years.
On Mon, 15 Nov 2021 13:56:18 GMT, Alan Bateman wrote:
> I can't quite tell if you have something that runs into the issue or whether
> you just spotted the open issue
Hello Alan,
I just happened to notice this issue in JBS and thought of checking if there's
any interest in this fix. From the i
On Mon, 15 Nov 2021 12:58:45 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8227020?
>
> The linked issue talks about non-normalized paths contributing to the leak.
> However, the root cau
