Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-10-28 Thread Daniel Jeliński
> Clean up of various issues related to error handling and memory management Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Restore support for IPv6-only operation - Changes: - all: https://git.openjdk.java.net/jdk

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-10-28 Thread Daniel Jeliński
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Restore support for IPv6-only operati

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-10-28 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. Thank you for your reply. I understand we have no need to fix the JD

Withdrawn: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-10-28 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. This pull request has been closed without being integrated. ---

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-10-28 Thread Daniel Fuchs
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Restore support for IPv6-only operati

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-10-28 Thread Daniel Jeliński
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Restore support for IPv6-only operati

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]

2021-10-28 Thread Ludvig Janiuk
> Single-row table was being used for visual effect, but a description list > seems more appropriate. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: Removed html fluff - Changes: - all: https://git.openjdk.java.net/

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-28 Thread Ludvig Janiuk
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. Done. I'm happy to drop them, I was just trying to keep the visuals as close to the original as possible. ![image](https://user-images.gi

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-10-28 Thread Daniel Fuchs
On Thu, 28 Oct 2021 11:15:16 GMT, Daniel Jeliński wrote: > Just to clarify, no tests were run. The failure was reported by JTReg itself. > As of now building Java on Windows requires IPv4. Understood. I'm satisfied that you manually tested the results on your machine - and if that change passe

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]

2021-10-28 Thread Jonathan Gibbons
On Thu, 28 Oct 2021 12:11:33 GMT, Ludvig Janiuk wrote: >> Single-row table was being used for visual effect, but a description list >> seems more appropriate. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Removed html f

Integrated: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-28 Thread Ludvig Janiuk
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. This pull request has now been integrated. Changeset: abe52aea Author:Ludvig Janiuk Committer: Jonathan Gibbons URL: https:/

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v2]

2021-10-28 Thread Daniel Jeliński
On Thu, 28 Oct 2021 14:27:15 GMT, Daniel Fuchs wrote: > I still need to review it though Each commit tries to fix one function (memory allocation / deallocation / return values); it may be easier to review them one by one. > I assume we're talking about using `GetIfTable2` and `GetIfEntry2` Y