On Tue, 19 Oct 2021 13:48:24 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Sun, 17 Oct 2021 21:03:56 GMT, Mark Sheppard wrote:
> getByName requires a hostname lookup and getByAdress requires (eventually - I
> know the docs says there’s no reverse lookup) an address reverse lookup.
> Thus, a logical mapping is getByName —> lookupHostname, and getByAddr —>
> lookupA
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The following API classes are added to `java.net.spi` package to facilitate
> this:
> -
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Wed, 20 Oct 2021 12:12:21 GMT, Daniel Fuchs wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adapt line length to 80 column display
>
> Hmm... JDK-8225239 might have introduced a bug.
> I see that with the cu
On Wed, 20 Oct 2021 13:38:17 GMT, Daniel Jeliński wrote:
>> Hmm... JDK-8225239 might have introduced a bug.
>> I see that with the current code neither `enumAddresses_win` nor
>> `enumAddresses_win_ipaddrtable` will return -2 - so there appears to be some
>> dead code. I suspect that this line
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Thu, 14 Oct 2021 17:29:16 GMT, Daniel Jeliński wrote:
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to
On Wed, 20 Oct 2021 13:53:21 GMT, Daniel Fuchs wrote:
>> Thanks @dfuch and @AlanBateman for the review and all your help.
>>
>> @dfuch I'd rather follow up on the remaining issues in a separate PR. This
>> one is already doing more than the PR title advertises.
>
> @djelinski I have no objectio
> Hi,
>
> Please review my fix for JDK-8274779 which changes how HttpClient and
> HttpsClient checks for equality when comparing request methods.
>
> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
> rather than the "POST" String literal, the old behaviour resulted in
On Tue, 19 Oct 2021 13:48:24 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Fri, 15 Oct 2021 15:11:06 GMT, Michael McMahon wrote:
> Just wondering what actually happens if you encounter this bug? I guess that
> the post will fail somehow because it has been given a closed connection. If
> so, would it be possible to write the test to simulate that behavior?
>
> So,
On Tue, 19 Oct 2021 17:19:08 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added setInCache to HttpClientAccess to replace reflection
>
> test/jdk/sun/net/www/http/RequestMethodCheck/RequestMetho
On Wed, 20 Oct 2021 14:52:45 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
> Hi,
>
> Please review my fix for JDK-8274779 which changes how HttpClient and
> HttpsClient checks for equality when comparing request methods.
>
> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
> rather than the "POST" String literal, the old behaviour resulted in
On Wed, 20 Oct 2021 14:52:45 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
21 matches
Mail list logo
