On Wed, 20 Oct 2021 12:12:21 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adapt line length to 80 column display > > Hmm... JDK-8225239 might have introduced a bug. > I see that with the current code neither `enumAddresses_win` nor > `enumAddresses_win_ipaddrtable` will return -2 - so there appears to be some > dead code. I suspect that this line here is wrong: > > https://github.com/openjdk/jdk/blob/a6c89e231872e7fab236ed87b5ccf44a189d6786/src/java.base/windows/native/libnet/NetworkInterface.c#L516 > it should be returning `ret` not `NULL` Thanks @dfuch and @AlanBateman for the review and all your help. @dfuch I'd rather follow up on the remaining issues in a separate PR. This one is already doing more than the PR title advertises. ------------- PR: https://git.openjdk.java.net/jdk/pull/5956
