> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
On Thu, 24 Jun 2021 15:06:49 GMT, Daniel Fuchs wrote:
>>> I've created an issue to track this:
>>> https://bugs.openjdk.java.net/browse/JDK-8269288
>>
>> Thanks. So are you keeping the Objects.requireNonNull here? If so then it
>> should probably be the 2-arg version so that the message is cle
On Fri, 25 Jun 2021 10:25:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Fri, 25 Jun 2021 10:25:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Fri, 25 Jun 2021 10:56:15 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
On Fri, 25 Jun 2021 11:37:50 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/DatagramSocket.java line 1398:
>>
>>> 1396: DatagramSocketImpl impl =
>>> factory.createDatagramSocketImpl();
>>> 1397: Objects.requireNonNull(impl,
>>> 1398:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
On Fri, 25 Jun 2021 11:48:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Fri, 25 Jun 2021 11:48:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Thu, 24 Jun 2021 15:15:07 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> confirm HttpExchange::sendResponseHeaders fails if key/value null
>
> src/jdk.httpserver/share/classes/com/sun/net/httpse
> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
> following format: First character uppercase, all other characters lowercase,
> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
> mutator methods of the class, in particular `putAll()` and `replace
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
-
Commit messages:
- 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
Changes: https://git.o
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Changes look good Max
-
Marked as reviewed by lancea (
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
LGTM.
-
Marked as reviewed by naoto (Reviewer).
PR: h
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
one more
--
15 matches
Mail list logo
