On Fri, 25 Jun 2021 10:56:15 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - 8253119: Added message to null check in java/net/DatagramSocket >> - Merge remote-tracking branch 'origin/master' into JDK-8253119 >> - 8253119: Removed redundant comments and USE_PLAINDATAGRAMSOCKET from >> java/net/DatagramSocket >> - Merge remote-tracking branch 'origin/master' into JDK-8253119 >> - 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl >> implementation > > src/java.base/share/classes/java/net/DatagramSocket.java line 1398: > >> 1396: DatagramSocketImpl impl = >> factory.createDatagramSocketImpl(); >> 1397: Objects.requireNonNull(impl, >> 1398: "Implementation returned by installed >> DatagramSocketFactoryImpl is null"); > > I think you mean "DatagramSocketImplFactory" instead of > "DatagramSocketFactoryImpl" here. Yes - good catch! I've been bitten by this before too :-) https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/net/DatagramSocketImplFactory.html ------------- PR: https://git.openjdk.java.net/jdk/pull/4574