> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental w
On Tue, 1 Jun 2021 17:46:10 GMT, Alan Bateman wrote:
>> Sorry about that. I've changed it now. See 2f179b5
>
> This still looks a bit messy because you've got 3 different styles in the one
> switch statement. It's okay to drop FileTime from the patch if you want as
> it's not worth spending tim
On Tue, 1 Jun 2021 16:58:12 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> com
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last revision:
On Wed, 2 Jun 2021 09:13:44 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/java.base/share/classes/java/nio/f
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>> with
On Fri, 26 Feb 2021 10:48:33 GMT, Сергей Цыпанов
wrote:
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
This pull request has been closed without being int
After I've renamed remove branch GitHub for some reason has closed original
https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
-
Commit messages:
- Merge branch 'master' into 8263561
- Merge branch 'master' into purge-linked-list
- 8263561: Use sized constru
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental w
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the annotation covering too big a portion it's easy to cal
On Fri, 21 May 2021 01:52:27 GMT, Weijun Wang wrote:
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the
Please find below a fix that will make
`java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to the
rare case where addresses bound to a network interfaces are updated while the
test is running.
Instead of using `NetworkInterface::equals` to compare network interfaces, the
t
On Wed, 2 Jun 2021 15:54:26 GMT, Daniel Fuchs wrote:
> Please find below a fix that will make
> `java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to
> the rare case where addresses bound to a network interfaces are updated while
> the test is running.
>
> Instead of usi
…ency on sun.net.www.MessageHeader and
-
Commit messages:
- JDK-8268133 : Update java/net/Authenticator tests to eliminate dependency on
sun.net.www.MessageHeader and
Changes: https://git.openjdk.java.net/jdk/pull/4317/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=43
On Wed, 2 Jun 2021 17:00:26 GMT, Alan Bateman wrote:
> I think this looks okay although returning false if ni1 or ni2 is subtle (it
> follows the Objects.equals check so it's okay but I did have to look at it
> twice).
Thanks Alan. I have added a comment to make it clearer.
-
PR:
> Please find below a fix that will make
> `java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to
> the rare case where addresses bound to a network interfaces are updated while
> the test is running.
>
> Instead of using `NetworkInterface::equals` to compare network interf
On Wed, 2 Jun 2021 17:52:34 GMT, Daniel Fuchs wrote:
>> Please find below a fix that will make
>> `java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to
>> the rare case where addresses bound to a network interfaces are updated
>> while the test is running.
>>
>> Instead
On Wed, 2 Jun 2021 17:22:01 GMT, Mahendra Chhipa
wrote:
> …ency on sun.net.www.MessageHeader and
test/jdk/java/net/Authenticator/B4722333.java line 79:
> 77: req.getResponseHeaders().set("Connection",
> "close");
> 78: req.getResponseHeaders().a
On Wed, 2 Jun 2021 17:52:34 GMT, Daniel Fuchs wrote:
>> Please find below a fix that will make
>> `java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to
>> the rare case where addresses bound to a network interfaces are updated
>> while the test is running.
>>
>> Instead
On Wed, 2 Jun 2021 15:23:01 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Wed, 2 Jun 2021 15:23:01 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
27 matches
Mail list logo
