On 28/04/2021 23:51, Pavel Rappo wrote:
On Wed, 28 Apr 2021 21:22:23 GMT, Daniel Fuchs wrote:
It also avoids relying on an unspecified behavior of `Assert.assertEquals`.
Which behavior is that? If I recall correctly, the test was written for TestNG
6.9.5, which provides a [method to compare
On Tue, 13 Apr 2021 15:39:17 GMT, Julia Boes wrote:
> Add two static factory methods to com.sun.net.httpserver.Filter that
> facilitate the creation of pre- and post-processing Filters:
>
> `public static Filter beforeResponse(String description,
> Consumer filterImpl) {}`
> `public static Fi
> Please find here an almost trivial test fix that should improve diagnostic in
> case of failures.
> It also avoids relying on an unspecified behavior of `Assert.assertEquals`.
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev e
On Thu, 29 Apr 2021 09:03:31 GMT, Daniel Fuchs wrote:
> Exactly - that API specification doesn't say whether elements
> that are arrays will be compared using shallow equals or deep
> equals.
Fair enough.
Since you are here, consider further improving diagnosability. The failed
comparison shou
> Please find here an almost trivial test fix that should improve diagnostic in
> case of failures.
> It also avoids relying on an unspecified behavior of `Assert.assertEquals`.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Improv
On Thu, 29 Apr 2021 10:25:39 GMT, Pavel Rappo wrote:
>> On 28\/04\/2021 23\:51\, Pavel Rappo wrote\:
>>> On Wed\, 28 Apr 2021 21\:22\:23 GMT\, Daniel Fuchs \>> openjdk\.org> wrote\:
>>>
It also avoids relying on an unspecified behavior of
\`Assert\.assertEquals\`\.
>>>
>>> Which beha
On Thu, 29 Apr 2021 11:28:26 GMT, Daniel Fuchs wrote:
>> Please find here an almost trivial test fix that should improve diagnostic
>> in case of failures.
>> It also avoids relying on an unspecified behavior of `Assert.assertEquals`.
>
> Daniel Fuchs has updated the pull request incrementally
> Please find here an almost trivial test fix that should improve diagnostic in
> case of failures.
> It also avoids relying on an unspecified behavior of `Assert.assertEquals`.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Rename
On Thu, 29 Apr 2021 11:38:21 GMT, Pavel Rappo wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved diagnostic message
>
> test/jdk/java/net/httpclient/websocket/WebSocketProxyTest.java line 179:
>
>> 177:
On Wed, 28 Apr 2021 21:22:23 GMT, Daniel Fuchs wrote:
> Please find here an almost trivial test fix that should improve diagnostic in
> case of failures.
> It also avoids relying on an unspecified behavior of `Assert.assertEquals`.
This pull request has now been integrated.
Changeset: 01415f3
10 matches
Mail list logo
