On Thu, 29 Apr 2021 11:28:26 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Please find here an almost trivial test fix that should improve diagnostic >> in case of failures. >> It also avoids relying on an unspecified behavior of `Assert.assertEquals`. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Improved diagnostic message Marked as reviewed by prappo (Reviewer). test/jdk/java/net/httpclient/websocket/WebSocketProxyTest.java line 179: > 177: var expected = ofBytes(b); > 178: var problem = actual.equals(expected) ? "match" : "differ"; > 179: return "%s and %s %s".formatted(actual, expected, problem); I would rename "problem" to more neutral "message" or "description". Ditto in the other file. ------------- PR: https://git.openjdk.java.net/jdk/pull/3776
