On Wed, 3 Mar 2021 05:01:13 GMT, Vyom Tewari wrote:
>>> HttpsURLConnection, works with SunJSSE provider but does not work with
>>> other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
>>> name as follows
>>>
>>> s = (SSLSocket)serverSocket;
>>> if (s instanceof SSLSocketIm
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 08:51:13 GMT, Vyom Tewari wrote:
>>> > HttpsURLConnection, works with SunJSSE provider but does not work with
>>> > other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
>>> > name as follows
>>> > s = (SSLSocket)serverSocket;
>>> > if (s instanceof SSLSoc
On Wed, 3 Mar 2021 04:27:15 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
Small fix to add logging to catch blocks where it was previously missing.
-
Commit messages:
- add logging
Changes: https://git.openjdk.java.net/jdk/pull/2808/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2808&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK
On Wed, 3 Mar 2021 10:55:12 GMT, Julia Boes wrote:
> Small fix to add logging to catch blocks where it was previously missing.
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2808
On Wed, 3 Mar 2021 10:05:24 GMT, Daniel Fuchs wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used List.of instead of Collections.singletonList
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.
On Wed, 3 Mar 2021 11:36:19 GMT, Vyom Tewari wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 454:
>>
>>> 452: s = (SSLSocket)factory.createSocket(serverSocket,
>>> 453: host, po
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 10:09:34 GMT, Daniel Fuchs wrote:
> Vyom, can you provide, or point to a test that exercises the code paths that
> have been changed? And also some new test that would fail before the fix and
> pass after?
>
> best regards,
>
> -- daniel
Hi Daniel,
there are multiple test
On Wed, 3 Mar 2021 15:10:54 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 16:16:48 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reverted the overly deleted else block
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java
On Wed, 3 Mar 2021 17:56:02 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Thu, 18 Feb 2021 21:43:00 GMT, Alex Menkov wrote:
> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test
> execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 15:20:29 GMT, Vyom Tewari wrote:
>> Vyom, can you provide, or point to a test that exercises the code paths that
>> have been changed? And also some new test that would fail before the fix and
>> pass after?
>>
>> best regards,
>>
>> -- daniel
>
>> Vyom, can you provide, o
On Thu, 4 Mar 2021 00:27:52 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - resolve jcheck issue.
>> - put if block which will prevent host being set twice in case of
>> SSLSocketImpl
>
>
On Thu, 4 Mar 2021 04:02:03 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
19 matches
Mail list logo
