On Wed, 3 Mar 2021 11:36:19 GMT, Vyom Tewari <[email protected]> wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 454:
>>
>>> 452: s = (SSLSocket)factory.createSocket(serverSocket,
>>> 453: host, port,
>>> true);
>>> 454: } else {
>>
>> This line should not have been deleted - otherwise NPE will arise later on -
>> e.g. at line 474. Has this change really been tested?
>
> right, i just saw failure(66) in my local environment. I wanted to delete
> only the below two lines.
> if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
> }
> I will update the PR soon, once my local test successful.
Hi Daniel, i updated the PR with your suggested change.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2583
