On Thu, 5 Nov 2020 17:56:00 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/SendResponseHeadersTest.java line 99:
>>
>>> 97: // unexpected exception thrown, return error to
>>> client
>>> 98: t.printStackTrace();
>>> 99: os.wr
On Fri, 6 Nov 2020 09:52:54 GMT, Chris Hegarty wrote:
>> This is executed on the server side - the Throwable here is the
>> AssertionError thrown by expectThrows if the expected exception is not
>> thrown. It is important to return this to the client side so that the client
>> side (main threa
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
On Thu, 5 Nov 2020 17:23:36 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8252304: Added read to TestHandler to ensure requestBody consumed before
>> closing exchange
>
> test/jdk/java/net
On Thu, 5 Nov 2020 17:30:32 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8252304: Added read to TestHandler to ensure requestBody consumed before
>> closing exchange
>
> test/jdk/java/ne
On Fri, 6 Nov 2020 10:49:10 GMT, Daniel Fuchs wrote:
>> Oh, ok. So the whole purpose of the catch block is to gracefully terminate
>> things (and trigger error reporting) if the test fails - which it should
>> never do ;-) Ok, thanks. [ It's almost like the code would be more easily
>> under
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
On Fri, 6 Nov 2020 11:50:10 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my fix for JDK-8253005: 'Add `@throws
>> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>>
>> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
>> un
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
On Fri, 6 Nov 2020 12:49:48 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8253005: Restructured test to use @BeforeTest/@AfterTest
>
> test/jdk/java/net/httpclient/SendResponseHeadersTest.j
On Fri, 6 Nov 2020 16:47:17 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my fix for JDK-8253005: 'Add `@throws
>> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>>
>> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
>> un
On Thu, 5 Nov 2020 12:46:08 GMT, Conor Cleary wrote:
> The primary goal of this fix was to refactor
> NetworkInterface/UniqueMacAddressesTest.java to make use of the
> jdk.test.lib.NetworkConfiguration class instead of java.net.NetworkInterface.
> This was due to the original failure being rel
On Thu, 5 Nov 2020 17:17:14 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> com
This PR proposes to remove
1. JavaDoc `@author` tags with unclear semantics: `@author
unascribed|unattributed|unknown`
2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.java.net/jdk/pull/11
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote:
> This PR proposes to remove
> 1. JavaDoc `@author` tags with unclear semantics: `@author
> unascribed|unattributed|unknown`
> 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters
A removed @author tag is a good @autho
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote:
> This PR proposes to remove
> 1. JavaDoc `@author` tags with unclear semantics: `@author
> unascribed|unattributed|unknown`
> 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters
Marked as reviewed by mr (Lead).
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote:
> This PR proposes to remove
> 1. JavaDoc `@author` tags with unclear semantics: `@author
> unascribed|unattributed|unknown`
> 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters
Marked as reviewed by mchung (Reviewer
On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote:
> This PR proposes to remove
> 1. JavaDoc `@author` tags with unclear semantics: `@author
> unascribed|unattributed|unknown`
> 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters
Marked as reviewed by iris (Reviewer).
18 matches
Mail list logo
