> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
On Wed, 4 Nov 2020 12:16:09 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my fix for JDK-8253005: 'Add `@throws
>> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>>
>> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
>> un
On Wed, 4 Nov 2020 13:21:12 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
Hi,
Could someone please review our code for JDK-8252304: 'Seed an
HttpRequest.Builder from an existing HttpRequest'?
This RFR proposes a new factory method for creating a new `HttpRequest` builder
from an existing `HttpRequest`.
This method can be used to build a new request equivalent to the
On Wed, 4 Nov 2020 14:51:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `Http
On Wed, 4 Nov 2020 14:51:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `Http
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
On Wed, 4 Nov 2020 15:18:01 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existing `Ht
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecified in its javadoc. This fix adds an `@throws IOException` to
On Wed, 4 Nov 2020 13:21:12 GMT, Chris Hegarty wrote:
> Please add a new test that asserts the newly specified condition ( if the
> response headers have already been sent) for where IOException can be thrown.
Test added as requested:
https://github.com/openjdk/jdk/pull/1014/commits/0c5c774424
11 matches
Mail list logo
