On Wed, 4 Nov 2020 12:16:09 GMT, Patrick Concannon <pconcan...@openjdk.org> wrote:
>> Hi, >> >> Could someone please review my fix for JDK-8253005: 'Add `@throws >> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ? >> >> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is >> unspecified in its javadoc. This fix adds an `@throws IOException` to its >> specification and a description of the conditions under which the exception >> is thrown. >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into JDK-8253005 > - Merge remote-tracking branch 'origin/master' into JDK-8253005 > - Merge remote-tracking branch 'origin/master' into JDK-8253005 > - Merge remote-tracking branch 'origin/master' into JDK-8253005 > - 8253005: Add `@throws IOException` in javadoc for > `HttpEchange.sendResponseHeaders` Please add a new test that asserts the newly specified condition ( if the response headers have already been sent) for where IOException can be thrown. ------------- Changes requested by chegar (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1014
