On Tue, 13 Oct 2020 19:09:44 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon w
On Fri, 9 Oct 2020 14:55:25 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon wr
On Wed, 14 Oct 2020 11:04:08 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
On Tue, 13 Oct 2020 15:50:57 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unixdomainchannels: updates from Chris's review 9 Oct 2020
>
> src/java.base/share/classes/java/net/UnixDomainSocket
On Wed, 14 Oct 2020 11:37:09 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
On Fri, 9 Oct 2020 14:36:44 GMT, Michael McMahon wrote:
>> test/jdk/java/nio/channels/unixdomain/IOExchanges.java line 113:
>>
>>> 111: SPINBAccep_NBConn_NBIO_WR_11a
>>> 112: SPINBAccep_NBConn_NBIO_RW_12a
>>> 113: */
>>
>> I recognise this test ;-) I thought there was a ver
On Tue, 13 Oct 2020 19:09:44 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon w
On Wed, 14 Oct 2020 13:17:01 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java line 63:
>>
>>> 61: /** Return the, possibly empty, set of extended socket options
>>> available. */
>>> 62: public final Set> unixOptions() { return
>>> unixO
On Wed, 14 Oct 2020 11:19:59 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
On Wed, 14 Oct 2020 12:24:11 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
On Wed, 14 Oct 2020 12:28:04 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
On Wed, 14 Oct 2020 13:56:42 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
On Wed, 14 Oct 2020 14:14:48 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
On Wed, 14 Oct 2020 14:21:13 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 22 additional commits
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
On Wed, 14 Oct 2020 18:27:32 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon w
18 matches
Mail list logo
