On Tue, 13 Oct 2020 15:50:57 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unixdomainchannels: updates from Chris's review 9 Oct 2020
>
> src/java.base/share/classes/java/net/UnixDomainSocketAddress.java line 134:
>
>> 132: if (fs.getClass().getModule() != Object.class.getModule()) {
>> 133: throw new IllegalArgumentException();
>> 134: }
>
> I believe it would be better if this verification was done outside of the
> constructor (you could do it in the of(Path)
> static factory method) - this would avoid creating the object if the path is
> invalid.
Good point.
-------------
PR: https://git.openjdk.java.net/jdk/pull/52
