Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-04 Thread Alan Bateman
On Fri, 2 Oct 2020 13:17:04 GMT, Michael McMahon wrote: >> make/modules/java.base/Copy.gmk line 195: >> >>> 193:$(call MakeTargetDir) >>> 194:$(RM) $@ $@.tmp >>> 195:$(foreach f,$(NET_PROPERTIES_SRC_LIST),$(CAT) $(f) >> $@.tmp;) >> >> This can be simplified. Cat takes mu

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-04 Thread Michael McMahon
On Sun, 4 Oct 2020 08:27:39 GMT, Alan Bateman wrote: >> Good points. I will update as suggested. Thanks. > > I would prefer if we didn't rename net.properties. Can we use the same > approach as lib/security/default.policy where > the share and platform specific are concatenated? Okay, I have ju

Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-04 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use