On Fri, 2 Oct 2020 13:17:04 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> make/modules/java.base/Copy.gmk line 195: >> >>> 193: $(call MakeTargetDir) >>> 194: $(RM) $@ $@.tmp >>> 195: $(foreach f,$(NET_PROPERTIES_SRC_LIST),$(CAT) $(f) >> $@.tmp;) >> >> This can be simplified. Cat takes multiple files as input, so no need for >> 'foreach'. Also no need to go via a temp >> file. We have make configured to delete targets if a recipe fails, so the >> tmp dance isn't needed. (I know we still have >> this pattern all over the place, but we are trying to quit the practice) > > Good points. I will update as suggested. Thanks. I would prefer if we didn't rename net.properties. Can we use the same approach as lib/security/default.policy where the share and platform specific are concatenated? ------------- PR: https://git.openjdk.java.net/jdk/pull/52
