RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

Hello, Request to have my fix reviewed for issue: JDK-8251715:  Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext. This fix updates jdk.internal.net.http.HttpClientImpl to throw an UncheckedIOExcep

Re: RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

Hi Rahul, Looks fine to me - but just one detail in the test: maybe you should use `expectThrows` rather than `assertThrows` and then double check that the exception you get is the one you expect. best regards, -- daniel On 18/08/2020 10:21, Rahul Yadav wrote: Hello, Request to have my fix r

Re: RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

Good point Daniel, i have included the feedback , updated webrev. - rahul On 18/08/2020 10:39, Daniel Fuchs wrote: Hi Rahul, Looks fine to me - but just one detail in the test: maybe you should use `expectThrows` rather than `assertThrows` and then double check that the exception you get is th

Re: RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

Rahul, > On 18 Aug 2020, at 10:21, Rahul Yadav wrote: > > ... > > Issue: https://bugs.openjdk.java.net/browse/JDK-8251715 > webrev: http://cr.openjdk.java.net/~ryadav/webrev_8251715/index.html > This looks good. In the test, i see that you have used expectThrows. expectThrows returns the ex

Re: RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

OK - only checking that it's an UncheckedIOException is probably sufficient there (though you could have done that with asserThrows. Reviewed. -- daniel On 18/08/2020 12:35, Rahul Yadav wrote: Good point Daniel, i have included the feedback , updated webrev. - rahul O

Re: RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

Hi Chris, Thanks for the feedback, this improves the test, i have included your feedback and updated webrev. - rahul On 18/08/2020 14:28, Chris Hegarty wrote: Rahul, On 18 Aug 2020, at 10:21, Rahul Yadav wrote: ... Issue: https://bugs.openjdk.java.net/browse/JDK-8251715 webrev: http://

Re: RFR 8251715 : Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext.

> On 18 Aug 2020, at 16:06, Rahul Yadav wrote: > > Hi Chris, > > Thanks for the feedback, this improves the test, i have included your > feedback and updated webrev. Looks better. Before pushing, please check the indentation ( as it appears a little off in the webrev ), and print the excep

Re: Fix for Javadoc errors in java.base

Hi, The two changes below still need to be reviewed. Any takers? Cheers, Julia --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14 23:55:41.953638446 +0530 +++ new/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafa

Re: Fix for Javadoc errors in java.base

Looks fine. Thanks Mandy On 8/18/20 10:02 AM, Julia Boes wrote: Hi, The two changes below still need to be reviewed. Any takers? Cheers, Julia --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14 23:55:41.953638446 +0530 +++ new/src/jav