Rahul, > On 18 Aug 2020, at 10:21, Rahul Yadav <rahul.r.ya...@oracle.com> wrote: > > ... > > Issue: https://bugs.openjdk.java.net/browse/JDK-8251715 > webrev: http://cr.openjdk.java.net/~ryadav/webrev_8251715/index.html > This looks good.
In the test, i see that you have used expectThrows. expectThrows returns the exception ( after the type check has occurred ), it is possible to do further checking on it, like say for example examining its cause, or exception message. Unless you do further checking or diagnostic output, then there is not much difference between assertThrows and expectThrows. Maybe you mean to check the cause for NoSuchAlgorithmException? -Chris.
