RFR[8250886]: java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout

2020-08-06 Thread Patrick Concannon
Hi, Could someone please review my fix for JDK-8250886 — ‘java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout’ ? The default value of SO_RCVBUF is much larger than the SO_SNDBUF limit so it no longer needs to be set to match it. This mismatch caused the corresponding test 'java/ne

Re: RFR[8250886]: java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout

2020-08-06 Thread Alan Bateman
On 06/08/2020 13:29, Patrick Concannon wrote: Hi, Could someone please review my fix for JDK-8250886 — ‘java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout’ ? The default value of SO_RCVBUF is much larger than the SO_SNDBUF limit so it no longer needs to be set to match it. This

Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-08-06 Thread Alan Bateman
On 04/08/2020 16:36, Nikola Grcevski wrote: Hi Alan, What cheap is VerifyVersionInfoW? The check is done everytime but the overhead might be in the noise. Overall it looks good to me. I wrote a small benchmark to measure the overhead of the version check (attached below). On my SurfaceBook

Re: RFR[8250886]: java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout

2020-08-06 Thread Daniel Fuchs
Hi Patrick, Thanks for the good detective work in finding the reason for the test failure. The proposed change looks good to me! Good riddance :-) Since this is not a test bug after all, can you add 8250886 to the @bug clause in the test? best regards, -- daniel On 06/08/2020 13:29, Patrick C

RE: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-08-06 Thread Nikola Grcevski
Yes, please. Thank you, Nikola -Original Message- From: Alan Bateman Sent: August 6, 2020 9:49 AM To: Nikola Grcevski ; net-dev@openjdk.java.net Subject: Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter On 04/08/2020 16:36, Nikola Grcevski wrote: > H