Hi Patrick, Thanks for the good detective work in finding the reason for the test failure.
The proposed change looks good to me! Good riddance :-) Since this is not a test bug after all, can you add 8250886 to the @bug clause in the test? best regards, -- daniel On 06/08/2020 13:29, Patrick Concannon wrote:
Hi, Could someone please review my fix for JDK-8250886 — ‘java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout’ ? The default value of SO_RCVBUF is much larger than the SO_SNDBUF limit so it no longer needs to be set to match it. This mismatch caused the corresponding test 'java/net/DatagramSocket/SendReceiveMaxSize.java` to fail. The proposed fix is to leave SO_RCVBUF as configured by default by the kernel. issue: https://bugs.openjdk.java.net/browse/JDK-8250886 webrev: http://cr.openjdk.java.net/~pconcannon/8250886/webrevs/webrev.00/ Kind regards, Patrick
