Hi Daniel,
Thanks for your reply.
I’ve made the changes you’ve requested and you can find them in the updated
webrev below.
http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.02/
Kind regards,
Patrick
> On 20 Jul 2020, at 15:09, Daniel Fuchs wrote:
>
> Hi Patrick,
>
> test/jdk/j
Hi Patrick,
I think it mostly looks good.
Is there a reason why
jdk/java/net/DatagramSocket/SendReceiveMaxSize.java
*only* tests the old impl?
Shouldn't the test work with the new impl as well?
best regards,
-- daniel
On 30/07/2020 10:56, Patrick Concannon wrote:
Hi Daniel,
Thanks for your
On 30/07/2020 10:56, Patrick Concannon wrote:
Hi Daniel,
Thanks for your reply.
I’ve made the changes you’ve requested and you can find them in the updated
webrev below.
http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.02/
DatagramChannel/SendReceiveMaxSize.java. I think the
Hi,
Daniel: I’ve added in the relevant tags so now the tests should run on both
implementations.
Alan: Thanks for your comments. I’ve made those changes and you can find them
in the new webrev below
http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.03/
Kind regards,
Patrick
> On
Hi Patrick,
This looks good to me now.
Reviewed.
best regards,
-- daniel
On 30/07/2020 16:51, Patrick Concannon wrote:
Hi,
Daniel: I’ve added in the relevant tags so now the tests should run on both
implementations.
Alan: Thanks for your comments. I’ve made those changes and you can find
On 30/07/2020 16:51, Patrick Concannon wrote:
Hi,
Daniel: I’ve added in the relevant tags so now the tests should run on both
implementations.
Alan: Thanks for your comments. I’ve made those changes and you can find them
in the new webrev below
http://cr.openjdk.java.net/~pconcannon/8242885/
