Hi, Daniel: I’ve added in the relevant tags so now the tests should run on both implementations.
Alan: Thanks for your comments. I’ve made those changes and you can find them in the new webrev below http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.03/ Kind regards, Patrick > On 30 Jul 2020, at 13:20, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 30/07/2020 10:56, Patrick Concannon wrote: >> Hi Daniel, >> >> Thanks for your reply. >> >> I’ve made the changes you’ve requested and you can find them in the updated >> webrev below. >> >> http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.02/ >> > DatagramChannel/SendReceiveMaxSize.java. I think the @summary should be > changed to make it clear that it tests send and receiving datagrams of > maximum size (it's no longer a test for SO_SNDBUF) Also in > testSendReceiveMaxSize it would be clear if "r" and "s" could be renamed to > "receiver" and "sender" (there's overuse of var in this method so important > to use good names). > > -Alan
