Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

2020-06-23 Thread Alan Bateman
On 18/06/2020 09:02, Vyom Tiwari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8237858/webrev0.4/index.html) where i fix the build issue as well. The update to linux_close.c and bsd_close.c look okay but please use "if (timeout > 0) {" to keep the code consiste

Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

2020-06-23 Thread Daniel Fuchs
Hi Vyom, Just to let you know that the new SocketAcceptInterruptTest test seems to have some stability issues. Patrick imported your test and ran it on our test system. We got one crash (SIGSEV) on macOS with the first @run that uses the old impl, and a timeout with the second @run that uses the

8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request

2020-06-23 Thread Daniel Fuchs
Hi, Please find below a fix for: 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request https://bugs.openjdk.java.net/browse/JDK-8245462 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8245462/webrev.00/index.html The fix goes beyond fixing

Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

2020-06-23 Thread Vyom Tiwari
Hi Daniel/Alan, Thanks for the review , I was not sure how JVM/JDK handles the signals that's why I installed my own signal handler. As you both pointed out, I removed the custom signal handler in NativeThread. Please find the latest webrev( http://cr.openjdk.java.net/~vtewari/8237858/webrev0.5/i

Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

2020-06-23 Thread Alan Bateman
On 24/06/2020 05:53, Vyom Tiwari wrote: Hi Daniel/Alan, Thanks for the review , I was not sure how JVM/JDK handles the signals that's why I installed my own signal handler. As you both pointed out, I removed the custom signal handler in NativeThread. Please find the latest webrev(http://cr.

Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

2020-06-23 Thread Vyom Tiwari
Hi Alan, thanks for the review, i think there is some problem with webrev, in my local repo linux_close.c, bsd_close.c both are properly formatted. I will do the suggested changes in the tests and will send the updated webrev soon. Thanks, Vyom On Wed, Jun 24, 2020 at 11:49 AM Alan Bateman wro