On 18/06/2020 09:02, Vyom Tiwari wrote:
Hi,
Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8237858/webrev0.4/index.html) where i fix the build issue as well.

The update to linux_close.c and bsd_close.c look okay but please use "if (timeout > 0) {" to keep the code consistent.

I think the test needs a bit of work. The setup of the signal handler NativeThread_init doesn't look right - why is the test doing this? Also what is the reason for the signal handle trying to terminate the thread. It might be better to start again on the test and just have a thread asynchronously signalling another thread while it does timed and untimed blocking operations.

-Alan.


Reply via email to