[11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

Hi, Please review the backport of JDK-8183369 to 11u: Bug: https://bugs.openjdk.java.net/browse/JDK-8183369 Original change: https://hg.openjdk.java.net/jdk/jdk/rev/0ba758a2b6f0 11u webrev: http://cr.openjdk.java.net/~akasko/jdk11u/8183369/webrev.00/ Patch to HttpURLConnection applies cleanly

RE: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

Hi Alex, I think this looks good overall. There's one line in test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java, line 85, where you got the indentation wrong. Please check and fix that. Best regards Christoph > -Original Message- > From: jdk-updates-dev On > Behalf Of Alex

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

Hi Amy, Just a minor comment on the test usage of /othervm/java.security.policy=FilePublisherPermsTest3.policy -Djava.security.manager As jtreg tag-spec [1] suggested:   The setting of the system properties "java.security.manager" and "java.security.policy" in main/othervm actions is also d

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

> On 24 Mar 2020, at 15:01, Julia Boes wrote: > ... > > Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8235459/webrev.03/ LGTM. -Chris.

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

Hi Julia, * @run testng/othervm/java.security.policy=FilePublisherPermsTest1.policy Does this actually work as expected? I thought the syntax was: @run testng/othervm/policy= And FWIW there some subtlety with othervm/policy= versus othervm/policy== and I never remember which one should be

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

Hi Daniel, * @run testng/othervm/java.security.policy=FilePublisherPermsTest1.policy Does this actually work as expected? I thought the syntax was: @run testng/othervm/policy= I couldn't get the test to run with the latter but noticed that most tests that are run with testng use the 'java.s

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

OK, thanks for double checking Julia. Looks good to me then! best regards, -- daniel On 24/03/2020 16:33, Julia Boes wrote: Hi Daniel, * @run testng/othervm/java.security.policy=FilePublisherPermsTest1.policy Does this actually work as expected? I thought the syntax was: @run testng/other

Re: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

Hi Christoph, On 03/24/2020 12:36 PM, Langer, Christoph wrote: Hi Alex, I think this looks good overall. Thanks for the review! There's one line in test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java, line 85, where you got the indentation wrong. Please check and fix that. Sor

RE: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

Hi Alex, looks good now. Cheers Christoph > -Original Message- > From: Alex Kashchenko > Sent: Dienstag, 24. März 2020 19:09 > To: Langer, Christoph ; jdk-updates- > d...@openjdk.java.net > Cc: net-dev@openjdk.java.net > Subject: Re: [11u] RFR: 8183369: RFC unconformity of HttpURLConnec

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

Thank you Julia! Looks good to me. Thanks, Amy On 3/24/20 11:01 PM, Julia Boes wrote: Hi Amy, Just a minor comment on the test usage of /othervm/java.security.policy=FilePublisherPermsTest3.policy -Djava.security.manager As jtreg tag-spec [1] suggested:   The setting of the system propert