Hi Alex, looks good now.
Cheers Christoph > -----Original Message----- > From: Alex Kashchenko <akash...@redhat.com> > Sent: Dienstag, 24. März 2020 19:09 > To: Langer, Christoph <christoph.lan...@sap.com>; jdk-updates- > d...@openjdk.java.net > Cc: net-dev@openjdk.java.net > Subject: Re: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection > with proxy > > Hi Christoph, > > On 03/24/2020 12:36 PM, Langer, Christoph wrote: > > Hi Alex, > > > > I think this looks good overall. > > Thanks for the review! > > > > > There's one line in > test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java, line 85, > where you got the indentation wrong. Please check and fix that. > > Sorry for tabs on that line, not sure how they got there, updated webrev > after :retab : > > http://cr.openjdk.java.net/~akasko/jdk11u/8183369/webrev.01/ > > > > > Best regards > > Christoph > > > >> -----Original Message----- > >> From: jdk-updates-dev <jdk-updates-dev-boun...@openjdk.java.net> > On > >> Behalf Of Alex Kashchenko > >> Sent: Dienstag, 24. März 2020 12:29 > >> To: jdk-updates-...@openjdk.java.net > >> Cc: net-dev@openjdk.java.net > >> Subject: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection > with > >> proxy > >> > >> Hi, > >> > >> Please review the backport of JDK-8183369 to 11u: > >> > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8183369 > >> > >> Original change: https://hg.openjdk.java.net/jdk/jdk/rev/0ba758a2b6f0 > >> > >> 11u webrev: > >> http://cr.openjdk.java.net/~akasko/jdk11u/8183369/webrev.00/ > >> > >> Patch to HttpURLConnection applies cleanly, patch to > HttpURLConWithProxy > >> test was adjusted because mainline changes depend on JDK-8227539 that > >> was added in 14. > >> > >> -- > >> -Alex > > > > > -- > -Alex
