Thank you for reviewing, Vyom and Daniel.
Daniel, would you push the change for me?
Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8209178/webrev.02/
Cheers,
Julia
On 25/09/2019 13:12, Daniel Fuchs wrote:
Hi,
On 24/09/2019 16:11, Julia Boes wrote:
Hi,
This fix addresses an issue in
Hi,
Please find below a fix for a test that has been seeing failing
intermittently (once)...
https://bugs.openjdk.java.net/browse/JDK-8231037
8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently
due to reverse lookup failed
webrev:
http://cr.openjdk.java.net/~dfuchs/webre
A number of tests in the networking area invoke the no-args
URL::openConnection. If support for system proxies is enabled, the
default on macOS, then the built-in http(s) and ftp protocol handlers
may attempt to make a connection to a proxy. In almost all cases, this
is the wrong thing for the test
Hi Chris,
Thanks for doing that. It's similar to what we've also been doing
in each tests that was modified to use the wildcard.
I wonder if at some point we should also try to add an additional
@run main/othervm -Djava.net.preferIPv6Addresses to each test that
doesn't have it - but that will be
Hi Chris,
Thanks for your reply.
I've added the test case to
test/jdk/java/net/DatagramSocket/DatagramTimeout.java as requested.
You can find the new webrev here:
http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.01/
Kind regards,
Patrick
On 25/09/2019 18:02, Chris Hegarty
Mark,
> On 25 Sep 2019, at 19:52, mark.reinh...@oracle.com wrote:
>
> ...
>
> The URLConnection and HttpClient APIs already use the system’s default
> ProxySelector. What other APIs might require checking?
Ignoring SOCKS, that should be it.
> Do we care about SOCKS proxies? (Are those in bro
On 26/09/2019 14:26, Patrick Concannon wrote:
Hi Chris,
Thanks for your reply.
I've added the test case to
test/jdk/java/net/DatagramSocket/DatagramTimeout.java as requested.
You can find the new webrev here:
http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.01/
We should proba
On 26/09/2019 14:26, Patrick Concannon wrote:
I've added the test case to
test/jdk/java/net/DatagramSocket/DatagramTimeout.java as requested.
You can find the new webrev here:
http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.01/
Looks good to me Patrick!
best regards,
-- danie
Hi,
Please find below a patch for:
https://bugs.openjdk.java.net/browse/JDK-8231506
8231506: Fix some instabilities in a few networking tests
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8231506/webrev.00/
There's one remaining test that still uses the wildcard
(SocketImplCombinations).
> On 26 Sep 2019, at 13:15, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a fix for a test that has been seeing failing
> intermittently (once)...
>
> https://bugs.openjdk.java.net/browse/JDK-8231037
> 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently
> due to rev
> On 26 Sep 2019, at 15:16, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a patch for:
>
> https://bugs.openjdk.java.net/browse/JDK-8231506
> 8231506: Fix some instabilities in a few networking tests
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8231506/webrev.00/
LGTM.
-Chr
On 26/09/2019 15:16, Daniel Fuchs wrote:
Hi,
Please find below a patch for:
https://bugs.openjdk.java.net/browse/JDK-8231506
8231506: Fix some instabilities in a few networking tests
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8231506/webrev.00/
In SocketImplCombinations, the update
2019/9/26 6:34:19 -0700, chris.hega...@oracle.com:
>> On 25 Sep 2019, at 19:52, mark.reinh...@oracle.com wrote:
>>
>> Perhaps this is more a matter of test clean-up than anything else.
>
> For the tests I filed 8231504 - "Update networking tests to avoid
> implicit dependency on the system proxie
13 matches
Mail list logo
