Hi Chris,
Thanks for your reply.
I've added the test case to
test/jdk/java/net/DatagramSocket/DatagramTimeout.java as requested.
You can find the new webrev here:
http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.01/
Kind regards,
Patrick
On 25/09/2019 18:02, Chris Hegarty wrote:
Patrick,
On 25/09/2019 15:50, Patrick Concannon wrote:
Hi,
Would it be possible to have both my fix JDK-8222829, and CSR
JDK-8231401, reviewed?
This fix and CSR address the javadoc for
DatagramSocket::setSoTimeout, and make explicit that an
IllegalArgumentException will be thrown when passed a negative
timeout value.
webrev:
http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.00/
The changes look good.
I quickly checked, and can find no test for "setSoTimeout(-" in either
test/jdk/java/net or test/jdk/sun/net. Can you please add a trivial
test for it? Maybe add it to the existing
test/jdk/java/net/DatagramSocket/DatagramTimeout.java
Thanks,
-Chris.
