On 21/08/2019 07:55, Nick Gasson wrote:
Hi,
Bug: https://bugs.openjdk.java.net/browse/JDK-8229912
Webrev: http://cr.openjdk.java.net/~ngasson/8229912/webrev.0/
This test should be skipped if IPv6 is disabled on the host, and it
already has a shouldRun field to support this. But at the moment th
Hi Nick,
Thanks for finding this issue and proposing a fix.
I agree with Alan that throwing SkipException would be a better
choice, we have started using that more frequently recently.
In addition jdk.test.lib.NetworkConfiguration [1] provides a
static printSystemConfiguration method that could
Hi,
Thanks Alan and Daniel for the suggestions. I've made these changes here:
http://cr.openjdk.java.net/~ngasson/8229912/webrev.1/
Nick
On 21/08/2019 17:05, Daniel Fuchs wrote:
Hi Nick,
Thanks for finding this issue and proposing a fix.
I agree with Alan that throwing SkipException would b
On 21/08/2019 11:09, Nick Gasson wrote:
Hi,
Thanks Alan and Daniel for the suggestions. I've made these changes here:
http://cr.openjdk.java.net/~ngasson/8229912/webrev.1/
This looks okay to me.
Daniel - if there are other changes to this test then it might be worth
re-examining the ensur
On 21/08/2019 18:30, Alan Bateman wrote:
Daniel - if there are other changes to this test then it might be worth
re-examining the ensureXXX methods. The naming is very strange as they
return a boolean. Also they print messages to say that the test is
skipped but it's the caller that will determi
On 21/08/2019 11:45, Nick Gasson wrote:
On 21/08/2019 18:30, Alan Bateman wrote:
Daniel - if there are other changes to this test then it might be worth
re-examining the ensureXXX methods. The naming is very strange as they
return a boolean. Also they print messages to say that the test is
skip
Hi,
Thanks Alan for the suggestions. I've made those changes below:
http://cr.openjdk.java.net/~aefimov/pconcann/8078219/01/
Kind regards,
Patrick
On 20/08/2019 15:44, Alan Bateman wrote:
On 20/08/2019 15:27, Patrick Concannon wrote:
Hi,
Would it be possible to have my fix for JDK-80
On 21/08/2019 12:03, Patrick Concannon wrote:
Hi,
Thanks Alan for the suggestions. I've made those changes below:
http://cr.openjdk.java.net/~aefimov/pconcann/8078219/01/
This looks okay to me. Just a minor nit in GetURLsTest where we usually
prefer "static final" over "final static".
-Ala
On 21/08/2019 11:51, Alan Bateman wrote:
We could make those two methods return void and throw the
SkipException themselves? I don't mind doing that change in this patch.
I don't want to expand the scope of your changes, it was just a passing
comment. I think returning boolean is fine, I just th
I am newbie to Java.
we have on our environment
Linux kernel 4.9, java 1.8 version using tls 1.2 default
1. using curl when we give any https link , it returns within 2 seconds
2. using java program using httpurlconnection class we get 10 seconds or
more delay.
3. Even removed some ci
Ok, I will fix before pushing!
On 21/08/2019 13:09, Alan Bateman wrote:
y prefer "static final" over "final static".
Could I get the following trivial doc change reviewed please?
Bug report: https://bugs.openjdk.java.net/browse/JDK-8222363
Webrev: http://cr.openjdk.java.net/~michaelm/8222363/webrev.1/index.html
CSR: https://bugs.openjdk.java.net/browse/JDK-8229978
Thanks,
Michael.
Looks good to me Michael.
best regards,
-- daniel
On 21/08/2019 16:48, Michael McMahon wrote:
Could I get the following trivial doc change reviewed please?
Bug report: https://bugs.openjdk.java.net/browse/JDK-8222363
Webrev: http://cr.openjdk.java.net/~michaelm/8222363/webrev.1/index.html
C
On 21/08/2019 18:02, Daniel Fuchs wrote:
Looks good to me Michael.
Although it would be better to use {@linkplain #close() closed}
at line 714.
best regards,
-- daniel
best regards,
-- daniel
On 21/08/2019 16:48, Michael McMahon wrote:
Could I get the following trivial doc change review
14 matches
Mail list logo
