RE: RFR : 8227737: avoid implicit-function-declaration on AIX

2019-07-17 Thread Langer, Christoph
Hi Matthias, looks good, thanks for doing this. How far are we then from enabling "warnings as errors" on AIX? :P Best regards Christoph From: awt-dev On Behalf Of Baesken, Matthias Sent: Dienstag, 16. Juli 2019 17:04 To: Java Core Libs ; nio-...@openjdk.java.net; net-dev@openjdk.jav

RE: RFR : 8227737: avoid implicit-function-declaration on AIX

2019-07-17 Thread Baesken, Matthias
Thanks ! * How far are we then from enabling "warnings as errors" on AIX? :P * I count in the opt/product jdk/jdk AIX build currently 60 remaining matches of compiler warnings . Plus additionally a number of those (probably linker warnings ?) : 1500-029: (W) WARNING: subprogra

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-17 Thread Peter Levart
Hi Claes, Am I reading correct that package-private ClassLoader.loadLibrary(Class fromClass, String name, boolean isAbsolute) wouldn't need to consult SecurityManager wasn't it for accessing system properties in private ClassLoader.initializePath(String propName). So perhaps if the two calls

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-17 Thread Claes Redestad
Hi Peter, On 2019-07-17 10:29, Peter Levart wrote: Hi Claes, Am I reading correct that package-private ClassLoader.loadLibrary(Class fromClass, String name, boolean isAbsolute) wouldn't need to consult SecurityManager wasn't it for accessing system properties in private ClassLoader.initializ

RFR: 8227721: NetworkInterfaceRetrievalTests.java should open the java.net package

2019-07-17 Thread Patrick Concannon
Hi, Would it be possible to have my fix for JDK-8227721 reviewed? test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java has been recently modified to perform a deep reflection ( setAccessible(true) ) on a non-public member java.net.NetworkInterface::isBoundInetAddress. Howeve

Re: RFR: 8227721: NetworkInterfaceRetrievalTests.java should open the java.net package

2019-07-17 Thread Brian Burkhalter
Hi Patrick, Based on [1] this looks OK to me. Brian [1] https://openjdk.java.net/jtreg/tag-spec.html > On Jul 17, 2019, at 9:52 AM, Patrick Concannon > wrote: > > Would it be possible to have my fix for JDK-8227721 reviewed? > > test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTe

Re: RFR: 8227721: NetworkInterfaceRetrievalTests.java should open the java.net package

2019-07-17 Thread Chris Hegarty
> On 17 Jul 2019, at 17:52, Patrick Concannon > wrote: > > ... > Webrev for fix: http://cr.openjdk.java.net/~aefimov/pconcann/8227721/00/ Looks good Patrick. Reviewed. -Chris.

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-17 Thread Mandy Chung
On 7/17/19 3:25 AM, Claes Redestad wrote: Hi Peter, On 2019-07-17 10:29, Peter Levart wrote: Hi Claes, Am I reading correct that package-private ClassLoader.loadLibrary(Class fromClass, String name, boolean isAbsolute) wouldn't need to consult SecurityManager wasn't it for accessing syst