Hi Patrick, Based on [1] this looks OK to me.
Brian [1] https://openjdk.java.net/jtreg/tag-spec.html > On Jul 17, 2019, at 9:52 AM, Patrick Concannon <patrick.concan...@oracle.com> > wrote: > > Would it be possible to have my fix for JDK-8227721 reviewed? > > test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java has > been recently modified to perform a deep reflection ( setAccessible(true) ) > on a non-public member java.net.NetworkInterface::isBoundInetAddress. > However, an illegal access warning is generated by JTReg as a result. > > This fix sets the test to run in 'othervm' mode, and gives 'open' access to > 'java.net <http://java.net/>' to the unnamed module (where the test lives). > > Further information on this fix can be found here: > https://bugs.openjdk.java.net/browse/JDK-8227721 > <https://bugs.openjdk.java.net/browse/JDK-8227721> > > Webrev for fix: http://cr.openjdk.java.net/~aefimov/pconcann/8227721/00/ > <http://cr.openjdk.java.net/~aefimov/pconcann/8227721/00/>