Re: [ipv6] RFR: 8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly

Mark, The comparison by String was a reasonable choice when this mechanism was added. What is being proposed here expands the functionality so that logically equivalent IPv6 literals can be used without the need for additional entries. I did the following testing on my Linux box, Ubuntu 16.04, an

Re: [teststabilization] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6

Hi Aleksei, Nit: PerConnectionProxy.java: 88 InetSocketAddress isa = InetSocketAddress.createUnresolved(InetAddress.getLoopbackAddress().getHostAddress(), pserver.getPort()); If you had named `serverAddress` `loopback` then you could trivially reuse it at the line above and

Re: [ipv6] RFR: 8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported

Arthur, > On 11 May 2019, at 11:48, Chris Hegarty wrote: > > Arthur, > >> On 10 May 2019, at 17:37, Arthur Eubanks > > wrote: >> >> Sounds good. >> New webrev: http://cr.openjdk.java.net/~aeubanks/8223532/webrev.03/ >>

Re: [ipv6] RFR: 8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly

Hi Chris, yes understood, thanks for that ... all good :+1 ... just wanted to highlight how the current mechanism worked and that on a Windows lapper there is a potential anomaly with the standard platform names service with the reverse lookup scenario. regards Mark

Re: [teststabilization] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6

Hi Daniel, New webrev can be found here: http://cr.openjdk.java.net/~aefimov/8223638/02/ PerConnectionProxy.java - fixed as suggested. MultiReleaseJarURLConnection.java: I've added the toHttpJarURL method with small modifications: Test now uses the method only for the case with "jar:http". Fo

Re: [teststabilization] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6

Hi Aleksei, Looks good to me! best regards, -- daniel On 14/05/2019 12:22, Aleks Efimov wrote: Hi Daniel, New webrev can be found here: http://cr.openjdk.java.net/~aefimov/8223638/02/ PerConnectionProxy.java - fixed as suggested. MultiReleaseJarURLConnection.java: I've added the toHttpJa

RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Daniel, > > unfortunately, your proposed solution does not work with javac. I get this > in the build: > > Oh darn. I should have double checked. > Can we at least reduce the scope of the @SuppressedWarnings by > introducing a private method that just has the return call? Sure, what about thi

RFR: 8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work with IPv6 addresses

Hi, Some recent test stabilization fixes had a side effect on two FTP tests: now that the client might use the IPv6 loopback, the test might fail on IPv6 only hosts if the test server doesn't support the extended EPSV mode, or if the client isn't configured to use NO_PROXY and the default proxy s

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, That looks much better, thanks! (but still not commenting on the other changes ;-)) best regards, -- daniel On 14/05/2019 13:57, Langer, Christoph wrote: Hi Daniel, unfortunately, your proposed solution does not work with javac. I get this in the build: Oh darn. I should hav

RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Thanks Daniel. Can anybody help reviewing the changes to: src/java.base/share/classes/java/lang/invoke/MethodHandles.java src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java and src/java.management/share/classes/java/lang/management/ManagementFactory.java ? Thanks Christop

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, I'm very reluctant to see changes like this that the compiler folk have not determined are actually incorrect. That said ... On 15/05/2019 7:03 am, Langer, Christoph wrote: Thanks Daniel. Can anybody help reviewing the changes to: src/java.base/share/classes/java/lang/invoke/Me

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

I feel the same as David - reluctant to change anything. Introducing a raw type makes an ugly cast uglier. *From: *David Holmes > > > src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java > > As you note this should be ok'd by jsr166 folk so I've cc'd Martin > Buccholz. I