Hi Aleksei,

Looks good to me!

best regards,

-- daniel

On 14/05/2019 12:22, Aleks Efimov wrote:
Hi Daniel,

New webrev can be found here: http://cr.openjdk.java.net/~aefimov/8223638/02/

PerConnectionProxy.java - fixed as suggested.

MultiReleaseJarURLConnection.java:
I've added the toHttpJarURL method with small modifications:
Test now uses the method only for the case with "jar:http". For "http:" - it's been using only "http:" before the change. With "jar:" appended and without "!/" it fails with:

Caused by: java.lang.NullPointerException: no !/ in spec
        at 
java.base/sun.net.www.protocol.jar.Handler.parseAbsoluteSpec(Handler.java:168)
        at java.base/sun.net.www.protocol.jar.Handler.parseURL(Handler.java:150)
        at java.base/java.net.URL.<init>(URL.java:679)

Best Regards,
Aleksei


Reply via email to