Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread Thomas Stüfe
Hi David, (added net-dev, awt-dev, security-dev since part of these fixes are in their territory) On Mon, Mar 25, 2019 at 1:34 AM David Holmes wrote: > Hi Thomas, > > A few queries, comments and concerns ... > > On 25/03/2019 6:58 am, Thomas Stüfe wrote: > > Hi all, > > > > After a long time I

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread David Holmes
Hi Thomas, On 25/03/2019 5:01 pm, Thomas Stüfe wrote: Hi David, (added net-dev, awt-dev, security-dev since part of these fixes are in their territory) May be better to split up the reviews, cross-posting that many groups gets very messy given most people won't be subscribed to them all -

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread Thomas Stüfe
Hi David, Updating vs2017 did not help :/ Cheers, Thomas On Mon, Mar 25, 2019 at 8:17 AM David Holmes wrote: > Hi Thomas, > > On 25/03/2019 5:01 pm, Thomas Stüfe wrote: > > Hi David, > > > > (added net-dev, awt-dev, security-dev since part of these fixes are in > > their territory) > > May be

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread Thomas Stüfe
Hi all, Following David's suggestion, I withdraw this bug and will open issues for each area separately. Cheers, Thomas On Mon, Mar 25, 2019 at 1:44 PM Thomas Stüfe wrote: > Hi David, > > Updating vs2017 did not help :/ > > Cheers, Thomas > > On Mon, Mar 25, 2019 at 8:17 AM David Holmes > w

RFR(xxxs): 8221406: Windows 32bit build error in NetworkInterface_winXP.c

2019-03-25 Thread Thomas Stüfe
Hi all, please review this tiny fix to a windows 32 build warning: Issue: https://bugs.openjdk.java.net/browse/JDK-8221406 cr: http://cr.openjdk.java.net/~stuefe/webrevs/8221406-windows32-buildfixes-networkinterface_winxp.c/webrev.00/webrev/ Thanks, Thomas

Patch for JDK Bug 8173620

2019-03-25 Thread can comert
Hello everyone, I have created a commit for fixing the JDK Bug 8173620 which is documented here: https://bugs.openjdk.java.net/browse/JDK-8173620 Here is content for the commit for fixing the "Should not reach here" error in case of the call to underlying Proxy implementation throws an exception:

Re: Patch for JDK Bug 8173620

2019-03-25 Thread Alan Bateman
On 25/03/2019 15:46, can comert wrote: Hello everyone, I have created a commit for fixing the JDK Bug 8173620 which is documented here: https://bugs.openjdk.java.net/browse/JDK-8173620 Here is content for the commit for fixing the "Should not reach here" error in case of the call to underlyi

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread Alexey Ivanov
Hi Thomas, There was a thread about failing build on 32 bit Windows: http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023767.html It continued in February 2019: http://mail.openjdk.java.net/pipermail/build-dev/2019-February/024925.html Fast debug builds were affected. Likely there

Re: Patch for JDK Bug 8173620

2019-03-25 Thread can comert
Hello Alan, Thanks for your quick reply. Yes, I have found it in a commit as a part of JDK-8220493 as you said. http://hg.openjdk.java.net/jdk/jdk/rev/b5a73f22b2bd#l3.134 I think this should fix the issue, thanks for your help. Best Regards, Can Cömert Alan Bateman , 25 Mar 2019 Pzt, 16:59 ta

[RFR]: 8220575: Replace hardcoded 127.0.0.1 in URLs with new URI builder

2019-03-25 Thread Arthur Eubanks
Hi, This patch replaces hardcoded "http://127.0.0.1/"; in tests with a new URIBuilder and InetAddress.getLoopbackAddress().getHostAddress(). Creating a URIBuilder helper class was discussed in a previous thread on net-dev. http://cr.openjdk.java.net/~aeubanks/8220575/webrev.00/index.html One pro