Thanks Chris.
More extensive test campaign revealed that I missed another
wrapping point in HttpClientImpl::sendAsync.
New webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216498/webrev.01
best regards,
-- daniel
On 10/01/2019 20:18, Chris Hegarty wrote:
On 10 Jan 2019, at 18:23, Daniel
On 11/01/2019 11:20, Daniel Fuchs wrote:
Thanks Chris.
More extensive test campaign revealed that I missed another
wrapping point in HttpClientImpl::sendAsync.
New webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216498/webrev.01
Good catch. The updated webrev looks good.
-Chris.
Hi Ivan,
Shouldn't you resetlocalifsSize to 0 in case of the early return ? The
comment says localifsSize is the size of the array so the size of the array is
0 again after freeing.
637 static struct localinterface *localifs = 0;
638 static int localifsSize = 0;/* size of array
(and btw.There seem to be a few other places in the coding where the
realloc return value is not checked , see for example :
jdk/src/hotspot/share/adlc/forms.cpp
50void NameList::addName(const char *name) {
51 if (_cur == _max) _names =(const char**)realloc(_names,(_max
*=2)*sizeof
On 09/01/2019 15:20, Steve Groeger wrote:
...
I think I have an Linux system setup with a simarly configured interface
(system has IPv6 configured but interface
has no IPv6/INET6 address configured) but the test works fine when run
on that system.
This is what I observe too. Confirmed by l
Hi,
that's right, good catch. Either set localifs to 0 or maybe even keep the old
pointer with the old value of localifs. I guess the case is a bit theoretical
but it should be done right.
In line 695 fclose (f); the formatting can be fixed (also remove space
between fclose and the bracket
I think the difference is in setMulticastInterface() in
PlainDatagramSocketImpl.c
#ifdef __linux__
mcast_set_if_by_if_v4(env, this, fd, value);
if (ipv6_available()) {
if ((*env)->ExceptionCheck(env)){
(*env)->ExceptionClear(env);
}
Hi,
Please find below a fix for:
8216478: Cleanup HttpResponseImpl back reference to HttpConnection
https://bugs.openjdk.java.net/browse/JDK-8216478
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8216478/webrev.00/
HttpResponseImpl keeps an internal hard reference to the Exchange
and HttpCo
Good catch, thank you!
Indeed, if we don't reset localifsSize then we could end up accessing
already freed memory, which is worse than just a memory leak.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8007606/01/webrev/
With kind regards,
Ivan
On 1/11/19 4:43 AM, Baesken,
Thank you Christoph!
Mixed code formatting style is used in this file. There are too many
places where an extra space is put after a function name.
I think it's better to only fix the style on the already touched lines
to avoid blurring the fix.
With kind regards,
Ivan
On 1/11/19 9:04 A
Thank you Christoph!
Mixed code formatting style is used in this file. There are too many
places where an extra space is put after a function name.
I think it's better to only fix the style on the already touched lines
to avoid blurring the fix.
With kind regards,
Ivan
On 1/11/19 9:04 A
11 matches
Mail list logo
