Thank you Christoph!
Mixed code formatting style is used in this file. There are too many
places where an extra space is put after a function name.
I think it's better to only fix the style on the already touched lines
to avoid blurring the fix.
With kind regards,
Ivan
On 1/11/19 9:04 AM, Langer, Christoph wrote:
Hi,
that's right, good catch. Either set localifs to 0 or maybe even keep the old
pointer with the old value of localifs. I guess the case is a bit theoretical
but it should be done right.
In line 695 fclose (f); the formatting can be fixed (also remove space
between fclose and the bracket).
Thanks
Christoph
-----Original Message-----
From: net-dev <net-dev-boun...@openjdk.java.net> On Behalf Of
Baesken, Matthias
Sent: Freitag, 11. Januar 2019 13:43
To: net-dev@openjdk.java.net
Subject: [CAUTION] Re: RFR 8007606 : Handle realloc() failure in
unix/native/libnet/net_util_md.c correctly
Hi Ivan,
Shouldn't you reset localifsSize to 0 in case of the early return ? The
comment says localifsSize is the size of the array so the size of the array is 0
again after freeing.
637 static struct localinterface *localifs = 0;
638 static int localifsSize = 0; /* size of array */
639 static int nifs = 0; /* number of entries used in array */
...
679 if (localifsTemp == 0) {
680 free(localifs);
681 localifs = 0;
682 nifs = 0;
683 fclose(f);
684 return;
685 }
Best regards, Matthias
Date: Thu, 10 Jan 2019 20:29:08 -0800
From: Ivan Gerasimov <ivan.gerasi...@oracle.com>
To: "net-dev@openjdk.java.net" <net-dev@openjdk.java.net>
Subject: RFR 8007606 : Handle realloc() failure in
unix/native/libnet/net_util_md.c correctly
Message-ID: <3dc3c26b-fea7-2538-2c7a-bfa623f2f...@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Hello!
This seems to be the last use of realloc() without proper handling of a
failure.
Would you please help review a trivial fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8007606
WEBREV: http://cr.openjdk.java.net/~igerasim/8007606/00/webrev/
Thanks in advance!
--
With kind regards,
Ivan Gerasimov
--
With kind regards,
Ivan Gerasimov
