Re: RFR: 8189366: SocketInputStream.available() should check for eof

Hi Chris, Thanks for review, please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8189366/webrev0.1/index.html) where i included the test. Thanks, Vyom On Wednesday 10 October 2018 09:50 PM, Chris Hegarty wrote: Vyom, On 10/10/18 14:16, vyom tewari wrote: Hi All, Please p

[12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

Please review below small change to fix test sun/net/ftp/FtpURLConnectionLeak.Java, thanks Besides the original timeout issue, looks like the test not working as expected even the results is pass. Per test description, we expect FileNotFoundException and then verify connection closed, but look

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

Chris Y, > On 11 Oct 2018, at 09:45, Chris Yin wrote: > > Please review below small change to fix test > sun/net/ftp/FtpURLConnectionLeak.Java, thanks > > Besides the original timeout issue, looks like the test not working as > expected even the results is pass. Per test description, we expec

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

On Thursday 11 October 2018 02:15 PM, Chris Yin wrote: Please review below small change to fix test sun/net/ftp/FtpURLConnectionLeak.Java, thanks Besides the original timeout issue, looks like the test not working as expected even the results is pass. Per test description, we expect FileNot

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

> On 11 Oct 2018, at 12:02, vyom tewari wrote: > On Thursday 11 October 2018 02:15 PM, Chris Yin wrote: >> Please review below small change to fix test >> sun/net/ftp/FtpURLConnectionLeak.Java, thanks >> >> Besides the original timeout issue, looks like the test not working as >> expected eve

RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Could I get the following fix reviewed please? http://cr.openjdk.java.net/~michaelm/8203850/webrev.1/ Thanks, Michael

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Looks good to me Michael. You should be able to easily add new test cases for Origin and Referer to test/jdk/java/net/SpecialHeadersTest.java too. best regards, -- daniel On 11/10/2018 13:28, Michael McMahon wrote: Could I get the following fix reviewed please? http://cr.openjdk.java.net/~mi

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

> On 11 Oct 2018, at 13:58, Daniel Fuchs wrote: > > Looks good to me Michael. > > You should be able to easily add new test cases for Origin and > Referer to test/jdk/java/net/SpecialHeadersTest.java too. +1 -Chris.

Re: RFR: 8189366: SocketInputStream.available() should check for eof

> On 11 Oct 2018, at 09:03, vyom tewari wrote: > > Hi Chris, > > Thanks for review, please find the updated > webrev(http://cr.openjdk.java.net/~vtewari/8189366/webrev0.1/index.html) > where i included the test. Thanks. I think this is good. -Chris.

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Thanks Daniel. I updated that test with some new scenarios for end to end testing. http://cr.openjdk.java.net/~michaelm/8203850/webrev.2/ Michael On 11/10/2018, 13:58, Daniel Fuchs wrote: Looks good to me Michael. You should be able to easily add new test cases for Origin and Referer to test

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi Michael, Why the test: 219 if (response.statusCode() != 200) 220 throw new RuntimeException("illegal header was sent in request"); Shouldn't this always throw, regardless of the status code? best regards, -- daniel On 11/10/2018 16:56, Michael McMahon wrot

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi Daniel, I was allowing for the possibility that the implementation might silently discard the header. In that case, the server would send the 500 response after detecting the "Via" header. - Michael. On 11/10/2018, 17:32, Daniel Fuchs wrote: Hi Michael, Why the test: 219 if (

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi Michael, On 11/10/2018 17:36, Michael McMahon wrote: Hi Daniel, I was allowing for the possibility that the implementation might silently discard the header. In that case, the server would send the 500 response after detecting the "Via" header. I would agree if that was a JCK test, but her

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

> On 11 Oct 2018, at 18:05, Daniel Fuchs wrote: > > Hi Michael, > > On 11/10/2018 17:36, Michael McMahon wrote: >> Hi Daniel, >> I was allowing for the possibility that the implementation might silently >> discard the header. In that case, the server would send the 500 response >> after detec

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi, i did an quick check of the change: From: - E-Mail-Adresse des Nutzers, der die Anfrage stellte (heute unüblich). RFC 2616 sagt hierzu, dass der |From:| /nicht/ ohne ausdrückliche Genehmigung des Nutzers gesendet werden darf. Why this is now allowed

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

Hi, Chris H. Thanks for your review and comments, I just added a comment as you suggested and update new webrev as below, please have a review. http://cr.openjdk.java.net/~xyin/8187522/webrev.01/ Thanks, Chris Y. > On 11 Oct 2018, at 7:00 PM, Chris Hegarty wrote: > > Chris Y, > >> On 11 Oct

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

Hi, Vyom, Chris H. > On 11 Oct 2018, at 7:08 PM, Chris Hegarty wrote: > > > >> On 11 Oct 2018, at 12:02, vyom tewari > > wrote: >> On Thursday 11 October 2018 02:15 PM, Chris Yin wrote: >>> Please review below small change to fix test >>> sun/net/ftp/FtpURLConne